You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Refactor TokenBridge to use transient storage for the ReentrancyGuard implementation. Existing ReentrancyGuard implementation using transient storage exist in:
Note that transient storage is only available from Cancun, and currently all our L2 contracts are compiled for London. This is because we can generate ZK proofs for execution traces using London EVM rules.
Motivation
More gas efficient implementation of ReentrancyGuard
Tasks
Refactor TokenBridge to use transient storage for the ReentrancyGuard implementation
Acceptance criteria
Passing unit test for new implementation of ReentrancyGuard
Risks
If we compile the TokenBridge with EVM_VERSION: cancun, then we should eventually compile all L2 contracts with EVM_VERSION: cancun to minimize version skew. If however the prover is then unable to generate proofs of Cancun EVM execution, then finalization of L2->L1 messages should fail. The E2E tests should capture this.
E2E tests will break if provers are unable to generate proofs of Cancun EVM execution
Version skew of L2 contracts - some L2 contracts compile in London, other L2 contracts compile in Cancun
Upgrades of deployed contracts should not occur without i.) No version skew, ii.) provers being able to generate Cancun EVM execution proofs
Remember to
Add the documentation label in case there is an impact on the documentation
Add priority and team labels
Add Task for updating the Runbook or adding/updating existing metrics and alerts.
The text was updated successfully, but these errors were encountered:
Description
Refactor TokenBridge to use transient storage for the ReentrancyGuard implementation. Existing ReentrancyGuard implementation using transient storage exist in:
Note that transient storage is only available from Cancun, and currently all our L2 contracts are compiled for London. This is because we can generate ZK proofs for execution traces using London EVM rules.
Motivation
More gas efficient implementation of ReentrancyGuard
Tasks
Acceptance criteria
Risks
If we compile the TokenBridge with
EVM_VERSION: cancun
, then we should eventually compile all L2 contracts withEVM_VERSION: cancun
to minimize version skew. If however the prover is then unable to generate proofs of Cancun EVM execution, then finalization of L2->L1 messages should fail. The E2E tests should capture this.Remember to
documentation
label in case there is an impact on the documentationpriority
andteam
labelsThe text was updated successfully, but these errors were encountered: