Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add better logging and metric collection #20

Open
6 tasks
abizjak opened this issue Aug 5, 2021 · 0 comments
Open
6 tasks

Add better logging and metric collection #20

abizjak opened this issue Aug 5, 2021 · 0 comments
Labels
[Size] Medium [Type] Maintenance Cleanup or handling of technical debt. [Type] Task An additional feature or improvement.

Comments

@abizjak
Copy link
Contributor

abizjak commented Aug 5, 2021

Task description

The wallet-proxy does not record any metrics about the response latencies but it would be valuable to have them. Similarly, logging is sometimes inadequate for issue analysis.

  • Record or log response latencies. Logging would already be valuable, but the ideal would likely be to expose them in a standard way like we do with the node, so via Prometheus.
    • Response time from database queries to the transaction log database.
    • Response time for node queries.
  • Log additional data with requests.
    • For account creation transactions (in submitCredential) log the address of the account that would be created.
    • For transaction submission log the sender account (and maybe some other items from the header such as expiry and nonce).
@abizjak abizjak added [Size] Medium [Type] Maintenance Cleanup or handling of technical debt. [Type] Task An additional feature or improvement. labels Aug 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Size] Medium [Type] Maintenance Cleanup or handling of technical debt. [Type] Task An additional feature or improvement.
Projects
None yet
Development

No branches or pull requests

1 participant