Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove TransactionStatusResult and BirkParametersResult. #227

Open
vikt0r0 opened this issue Mar 6, 2023 · 2 comments
Open

Remove TransactionStatusResult and BirkParametersResult. #227

vikt0r0 opened this issue Mar 6, 2023 · 2 comments
Labels
good first issue Good for newcomers [Prio] Low Should be fixed if time permits but can be postponed. [Type] Change Request Some visible functionality should be change.

Comments

@vikt0r0
Copy link
Contributor

vikt0r0 commented Mar 6, 2023 •
edited
Loading

Description
Datatypes TransactionStatusResult and BirkParametersResult are just versions of TransactionStatus and BlockBirkParameters that contain a subset of the information carried.

Currently they seem to add an unnecessary level of indirection, so the codebase would benefit from these being removed.
@vikt0r0 vikt0r0 added [Type] Change Request Some visible functionality should be change. good first issue Good for newcomers [Prio] Low Should be fixed if time permits but can be postponed. labels Mar 6, 2023
@SamantaTarun
Copy link

I would like to work on this issue?

@abizjak
Copy link
Contributor

abizjak commented Mar 6, 2023

@tarunsamanta2k20 feel free to do so, and make a PR with the changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers [Prio] Low Should be fixed if time permits but can be postponed. [Type] Change Request Some visible functionality should be change.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@abizjak @vikt0r0 @SamantaTarun