Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend warning message if commission rates are wrong #148

Open
mh-concordium opened this issue May 25, 2022 · 1 comment
Open

Extend warning message if commission rates are wrong #148

mh-concordium opened this issue May 25, 2022 · 1 comment
Labels
[Type] Change Request Some visible functionality should be change.

Comments

@mh-concordium
Copy link
Contributor

mh-concordium commented May 25, 2022

Description
Id user sends transaction with the wrong commission rates, we just inform the user that the rates are wrong.
It would be nice to either show the exact ranges or if its easier, point to how it is possible to look for the correct rates. Concordium client consensus show-chain-parameters

Steps to Reproduce
Add baker with wrong commission rate.

Expected Result
Option 1: Show the exact range in the warning message.
Option 2: Show the command that shows the rates. consensus show-chain-parameters

Actual Result
We are just informing the user that commission rate is wrong.

Versions

  • Software Version: concordium-client_4.0.3-0

┆Issue is synchronized with this Jira Task by Unito

@mh-concordium mh-concordium added the [Type] Change Request Some visible functionality should be change. label May 25, 2022
@abizjak
Copy link
Contributor

abizjak commented May 31, 2022

Option 1 is preferred if it is not significantly more time consuming to do than option 2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Change Request Some visible functionality should be change.
Projects
None yet
Development

No branches or pull requests

2 participants