Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ungraceful handling of error caused by querying old node #147

Open
bisgardo opened this issue May 24, 2022 · 1 comment
Open

Ungraceful handling of error caused by querying old node #147

bisgardo opened this issue May 24, 2022 · 1 comment
Labels
[Prio] Low Should be fixed if time permits but can be postponed. [Type] Bug Something isn't working

Comments

@bisgardo
Copy link
Contributor

bisgardo commented May 24, 2022

Bug Description

When calling GetBakerList on a node v3.0.2 (the version currently running on mainnet) where the call isn't valid, the resulting error message isn't helpful:

$ stack run concordium-client -- --grpc-ip=service.internal.mainnet.concordium.software raw GetBakerList
gRPC error: not enough bytes

If pointing at testnet (which is running v4.0.11), the call is valid:

$ stack run concordium-client -- --grpc-ip=service.internal.testnet.concordium.com raw GetBakerList
[
    0,
    1,
    2,
    ...
]

Steps to Reproduce

Call concordium-client raw GetBakerList against a pre-4.x.x node.

Expected Result

A message saying that the call isn't valid because the node version is too old.

Actual Result

A low-level gRPC error.

Versions

  • Software Version: 4.0.3-0 (current tip of main; commit 8693a16e9b9ec1d100151e5139d8f3f4e6a8f285).

┆Issue is synchronized with this Jira Task by Unito

@bisgardo bisgardo added the [Type] Bug Something isn't working label May 24, 2022
@abizjak
Copy link
Contributor

abizjak commented May 24, 2022

This is related to the general issue #47

Errors are handled poorly in general.

@abizjak abizjak added the [Prio] Low Should be fixed if time permits but can be postponed. label May 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Prio] Low Should be fixed if time permits but can be postponed. [Type] Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants