Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Voting dApp Improvements #560

Open
dragosgd opened this issue Oct 29, 2024 · 0 comments
Open

Voting dApp Improvements #560

dragosgd opened this issue Oct 29, 2024 · 0 comments
Labels
[Type] Change Request Some visible functionality should be change.

Comments

@dragosgd
Copy link

dragosgd commented Oct 29, 2024

Description
While reviewing the Voting dApp tutorial, I discovered 3 potential improvements in the React frontend.

  1. No "another prompt is already open" error
  • on first try of clicking the "create election" button it opened the wallet, suggested a contract initialization
  • switched tab, wallet disappeared as a background window
  • now the button does not work anymore since the wallet is open, but there is no error notifying the user of that
  • as a potential fix, you can display the error "Another prompt already open"
  • E.g on this front-end(sctools) if you don't approve the transaction in the wallet but click back to the browser webpage (so that your Concordium wallet windows is now at the background). And you try to initiate a transaction again by clicking a button, you get the above error.
  1. Manually navigating to /create endpoint prompts 404 Not Found from nginx
  • if the user goes to that page via the setupElectionPage it will work, but not if he manually inputs the URL
    Screenshot 2024-10-29 at 16 32 11 (2)
  1. Change the name in browser tab to something suggestive, not "React app"
    355392B5-8A1C-4CA9-9A8B-9F1D855EE31F_4_5005_c

Steps to Reproduce
Already explained in the Description

Versions

  • Software Version: 1.1.3(latest deployed version)
  • OS: MacOS
  • Browser: Brave(chromium based)
@dragosgd dragosgd added the [Type] Change Request Some visible functionality should be change. label Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Change Request Some visible functionality should be change.
Projects
None yet
Development

No branches or pull requests

1 participant