-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unable to build all projects in solution on the winui branch #4390
Comments
Hello chingucoding, thank you for opening an issue with us! I have automatically added a "needs triage" label to help get things started. Our team will analyze and investigate the issue, and escalate it to the relevant team if possible. Other community members may also look into the issue and provide feedback 🙌 |
Ah, there is the issue. |
Ah I see. I'm building the project through Visual Studio. The first times it failed, but after running the build.bat file inside the build folder, the build errors for the UI tests project didn't seem to occur again and the tests ran fine. After cleaning the projects again though, trying to run the UI tests ended in a build issues and the tests not running. |
@azchohfi you mentioned you've merged these two branches together now I think, eh? |
Yes, the winui_unittests branch was merged into the winui branch. |
@chingucoding let us know if you have better luck now and what issues still remain. |
Well using VS, I'm still getting build errors https://gist.github.com/chingucoding/97da4bce3c21beead463ba85396c0518 Btw, tests seem to be running now. Btw², it seems that you also have the issue of the UI being created and not cleaned up; is that worth looking into? |
The SampleApp won't build in the branch out-of-the-box at the moment as there's not a package of the Monaco editor for WinUI 3 yet, that has to be built manually from Alex's branch in that repo. Eventually hope to have a package using WebView2 for it across platforms, but have been waiting for WebView2 to support hosting objects for scripting interop vs. doing manual messaging.
Is this only in WinUI or in UWP as well? Definitely appreciate any insight. |
Ah I see, that makes sense. So to a degree those build failures are expected. Should this issue be kept open then so people know that this is (partially) expected?
UWP test apps don't exhibit this behavior, so far only WinUI 3 apps do this (at least from what I have seen). |
You should still be able to build the solution from VS if you target Release/AnyCPU. That should not build the sample app and should just work. Or just run the build.bat command from the build folder. |
Ah I see. Building with Release/AnyCPU, two projects still fail to compile, below is the build log:
|
This is not happening on my box, neither on the build server, so I don't know exactly what is happening. Not sure if any of them fixes the issue. We don't want to change cache or anything like that so we need to find a better solution. Can you try updating to a newer version of Grpc.* and Google.Protobuf within all the UITests projects? I can't replicate your issue, so I don't know what would fix it. |
This seemed to fix one of the two projects failing, one project is still failing to build with VS:
However I think this is still somewhat to unsurprising on my machine. Running a NuGet fails, not having the project.assets.json then is not too surprising here. Not sure why NuGet restore fails though, it complains about projects not being compatible with the targeted UAPs for some libraries. |
Do you have the 19041 SDK installed? How about 18362? |
Hello, since I have the same issue, I did not open another one. NuGet cannot restore the Monaco.Editor 0.10.0 alpha package. |
@pellea Alex had built a local version off a branch he made of Monaco that supported the Windows App SDK, it's not in a feed anywhere. |
When using the winui branch, building the solution wth VS 2022 ends with a few projects failing to build. Build log: https://gist.github.com/chingucoding/5fd6d1cdf7b9e6fd297ce6a2c032b236
Context: I was trying to figure out why unit test projects for WinUI 3 were not working and the awesome @azchohfi suggested to checkout the winui branch and it's unit tests. Since building (and running them didn't work), I'm opening this issue for input and help.
The text was updated successfully, but these errors were encountered: