Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Groups with "no color" are broken ( from v1.2.45 onwards ) #234

Open
JorgeR81 opened this issue Oct 13, 2024 · 1 comment · May be fixed by #235
Open

[Bug]: Groups with "no color" are broken ( from v1.2.45 onwards ) #234

JorgeR81 opened this issue Oct 13, 2024 · 1 comment · May be fixed by #235
Assignees
Labels
bug Something isn't working

Comments

@JorgeR81
Copy link

JorgeR81 commented Oct 13, 2024

Frontend Version

From v1.2.45 onwards

Expected Behavior

The group is dark blue, if we select the "no color" option.

g0

Actual Behavior

There is no text in the group's header.
There is only a very dim color in the header. The rest of the group has no color.

g1

Steps to Reproduce

Change a group's color to "No color".

Debug Logs

.

Browser Logs

.

What browsers do you use to access the UI ?

Google Chrome

Other

Windows 10

When I noticed this, I tested multiple versions.

The issue started in this version: https://github.com/Comfy-Org/ComfyUI_frontend/releases/tag/v1.2.45

So, it was probably caused by this PR : Comfy-Org/ComfyUI_frontend#725

@webfiltered webfiltered added the bug Something isn't working label Oct 28, 2024
@webfiltered webfiltered transferred this issue from Comfy-Org/ComfyUI_frontend Oct 28, 2024
@webfiltered
Copy link
Collaborator

This could be useful as it is - possibly even in use? Title should be fixed, either way. Adding a "default colour" button below it would enable both functions.

But reverting the change in behaviour is straightforward enough.

@webfiltered webfiltered self-assigned this Oct 28, 2024
@webfiltered webfiltered linked a pull request Oct 28, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants