Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Better Groups: They should be selectable and easy to save, duplicate, and move in bundles #181

Open
1 task done
DrMechanica opened this issue Sep 27, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@DrMechanica
Copy link

DrMechanica commented Sep 27, 2024

Is there an existing issue for this?

  • I have searched the existing issues and checked the recent builds/commits

What would your feature do ?

Currently groups are unselectable which means they have to be moved one at a time. For big workflows where things are often rearranged this quickly becomes cumbersome to deal with. It also means there's no mechanism by which one can easily duplicate a group. The only way to do so currently is to copy and paste the nodes from the group you want to duplicate, then put the pasted nodes in their own group. This becomes time consuming quickly, and brings us to another point: because groups are unselectable they also cannot be saved as part of a template, meaning any nodes saved in a template must be regrouped upon placing a new instance of the template. All these things culminate to make groups sometimes more hassle than help.

Proposed workflow

  1. Group some nodes together
  2. Click the group's title bar to select it (clicking in body of group will be ignored, same as current behavior)
  3. Do any number of operations: copy, paste, save as template, select other groups and drag all together, opt+drag to duplicate
  4. Bonus: double click the group anywhere inside of it (OTHER than it's title bar) and it will select all nodes in the group.

Additional information

This would make workflow management so much less of a bear.

@DrMechanica DrMechanica added the enhancement New feature or request label Sep 27, 2024
@huchenlei huchenlei transferred this issue from Comfy-Org/ComfyUI_frontend Sep 28, 2024
@huchenlei
Copy link
Member

Group is a litegraph feature. Issue transferred to litegraph repo.

@webfiltered
Copy link
Collaborator

Update:

  • Group multi-select has now been added
  • Copy & paste is in progress
  • Including in templates is on my own list (but I'd also be happy if someone else beat me to it)

Perhaps of interest: groups can also now be nested.

@LukeG89
Copy link

LukeG89 commented Nov 4, 2024

@webfiltered You are doing a great job! 🚀

In this discussion, someone asked if groups could be resized from any corner:

@webfiltered
Copy link
Collaborator

Many thanks!

The very first roadblock I ran across after creating my first group - trying to resize the bottom-left corner. Instead ending up moving all of the nodes.

I only learned about holding ctrl when moving a group by reading the Litegraph code. It's probably documented somewhere - but I don't find it intuitive. There's a loose plan - likely will be mimicking desktop window UX.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants