Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: When dragging an image from the queue, replace the output image with the dragged in workflow's image #497

Open
1 task done
robinjhuang opened this issue Aug 18, 2024 · 2 comments · May be fixed by #1150
Assignees
Labels
enhancement New feature or request

Comments

@robinjhuang
Copy link
Member

Is there an existing issue for this?

  • I have searched the existing issues and checked the recent builds/commits

What would your feature do ?

Currently when you drag in an image to replace the existing workflow, the output image node does not update to the output image of the workflow that was just dragged in.

Proposed workflow

  1. Drag in output image from the queue
  2. Save Image node displays the image from the dragged in workflow

Additional information

No response

@robinjhuang robinjhuang added the enhancement New feature or request label Aug 18, 2024
@bezo97 bezo97 self-assigned this Oct 7, 2024
@bezo97
Copy link
Collaborator

bezo97 commented Oct 7, 2024

I'll take this request.
Up for discussion: what should happen when there are multiple SaveImage nodes in the workflow? We don't know which one saved the image. Saving it in the workflow feels overkill. My first idea is to take the last one in the processing order. It won't be correct in some cases but that's not a huge problem. Or I can just take all the SaveImage nodes. Any thoughts?

@bezo97 bezo97 linked a pull request Oct 7, 2024 that will close this issue
@huchenlei
Copy link
Member

I'll take this request. Up for discussion: what should happen when there are multiple SaveImage nodes in the workflow? We don't know which one saved the image. Saving it in the workflow feels overkill. My first idea is to take the last one in the processing order. It won't be correct in some cases but that's not a huge problem. Or I can just take all the SaveImage nodes. Any thoughts?

I think generally this is not doable without large change impact on other parts of the code base. To support fully load every output , we need to persist the queue history in a DB, and there will need to be a mechanism to map the generated asset to the task it was generated from.

If we are talking about just putting single asset that has workflow as metadata back to correct output node, the problem becomes simpler, which is just attach the output node id as part of the media metadata, and retrieve that accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants