Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Script broken after recent lsdvd update #6

Open
6b6279 opened this issue Jan 11, 2025 · 2 comments
Open

Script broken after recent lsdvd update #6

6b6279 opened this issue Jan 11, 2025 · 2 comments

Comments

@6b6279
Copy link

6b6279 commented Jan 11, 2025

With lsdvd 0.19 the script doesn't work. There is a new -Oj option that's supposed return a JSON (instead of -Oy) but this JSON output is not formatted correctly, so that switching -Oy to -Oj in the script doesn't fix the issue. Because -Oy and -Oj share code, somehow there is a regression with -Oy too, so that the "Python" output is also no longer parsable by mpv (dvd-browser fails with an empty error message and shows "insert dvd" when the Menu key is pressed). Downgrading to 0.17 seems to be only fix right now.

@CogentRedTester
Copy link
Owner

Can you post the outputs from -0j and -0y in both lsdvd 0.17 and 0.19?

@6b6279
Copy link
Author

6b6279 commented Jan 18, 2025

Version 0.19 is omitting commas (see example below) in -0y. I think it's best to create an issue for lsdvd, I don't think there is much the script can do if the output is simply incorrect.

    {
      'ix' : 1,
      'length' : 12.280,
      'vts_id' : "DVDVIDEO-VTS",
      'chapter' : [
        {
          'ix' : 1,
          'length' : 12.280,
          'startcell' : 1        }      ]
    }    {

compare to (version 0.17)

    {
      'ix' : 1,
      'length' : 12.280,
      'vts_id' : 'DVDVIDEO-VTS',
      'chapter' : [
        {
          'ix' : 1,
          'length' : 12.280,
          'startcell' : 1,
        },
      ],
    },
    {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants