You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I was trying to $i->disableExceptionHandling() and noticed that it wasn't actually getting taken care of. I would gladly PR this as it seems like a simple change:
Any objections to removing the 2nd condition from the if statement? From a "disable exception handling" standpoint I don't care if it's a laravel or symfony exception, I just want it to get re-thrown.
Any objections to this change?
It looks like @janhenkgerritsen is familiar with these issues in some capacity, so I am tagging for visibility!
The text was updated successfully, but these errors were encountered:
Laravel v7.10.3
I was trying to
$i->disableExceptionHandling()
and noticed that it wasn't actually getting taken care of. I would gladly PR this as it seems like a simple change:https://github.com/Codeception/module-laravel5/blob/bd2c604e8aa02d2b24737de01c6716473e8db96c/src/Codeception/Lib/Connector/Laravel5/ExceptionHandlerDecorator.php#L74
Any objections to removing the 2nd condition from the if statement? From a "disable exception handling" standpoint I don't care if it's a laravel or symfony exception, I just want it to get re-thrown.
Any objections to this change?
It looks like @janhenkgerritsen is familiar with these issues in some capacity, so I am tagging for visibility!
The text was updated successfully, but these errors were encountered: