Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dm_rockso not 3.6 compatable #1

Open
nopthetop opened this issue Apr 10, 2019 · 2 comments
Open

dm_rockso not 3.6 compatable #1

nopthetop opened this issue Apr 10, 2019 · 2 comments

Comments

@nopthetop
Copy link

The call to asyncio.run() on line 71 of dm_rockso is not compatible with Python 3.6. Causes the program to throw an exception and fail. Python 3.7 seems to work okay, had to upgrade. Not sure if it's a bug, but figured you'd want to know for compatibility reasons.

@panch0
Copy link

panch0 commented Apr 11, 2019

You are correct, I gotta either make it explicitly clear that 3.7 is required or better yet make the implementation support 3.6. I'll take a look sometime tonight.

Also, to be honest rockso needs to be re-implemented. The way its written right now it basically spams packets and waits for 5 seconds for responses to come in. Won't scale well to larger subnets. I think the right way to go about it is to wrap each request in a task object with a 5 second lifetime. I should have time tonight or this weekend to fix it!

Thanks for the heads up,
Victor

@biorchang
Copy link

I experienced the same error using Python 3.7. I am using a clean W10 build with the latest Python install and ran setup.py to install dependencies. Python in PATH.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants