Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetching imgur image does not work #196

Open
ghost opened this issue Oct 13, 2015 · 3 comments
Open

Fetching imgur image does not work #196

ghost opened this issue Oct 13, 2015 · 3 comments
Labels

Comments

@ghost
Copy link

ghost commented Oct 13, 2015

Getting this

Traceback (most recent call last):
File "/home/Chi/Cloudbot/cloudbot/plugin.py", line 376, in _execute_hook
out = yield from self.bot.loop.run_in_executor(None, self._execute_hook_threaded, hook, event)
File "/usr/lib/python3.4/asyncio/futures.py", line 348, in iter
yield self # This tells Task to wait for completion.
File "/usr/lib/python3.4/asyncio/tasks.py", line 351, in _wakeup
value = future.result()
File "/usr/lib/python3.4/asyncio/futures.py", line 243, in result
raise self._exception
File "/usr/lib/python3.4/concurrent/futures/thread.py", line 54, in run
result = self.fn(_self.args, *_self.kwargs)
File "/home/Chi/Cloudbot/cloudbot/plugin.py", line 340, in _execute_hook_threaded
return hook.function(*parameters)
File "/home/Chi/Cloudbot/plugins/imgur.py", line 108, in imgur
reddit_url = web.try_shorten("http://reddit.com" + item.reddit_comments)
AttributeError: 'GalleryImage' object has no attribute 'reddit_comments'

@edwardslabs
Copy link
Member

@lukeroge I can reproduce this for any subreddit imgur search. I can't find any reference to reddit_comments in imgurpython. Did they remove it or was that attribute sourced from somewhere else?

@ghost
Copy link
Author

ghost commented Oct 21, 2015

Pretty sure it's from here

https://api.imgur.com/endpoints/gallery#subreddit

"Response Model Gallery Images with 'reddit_comments' url"

@ghost
Copy link
Author

ghost commented Nov 27, 2015

Anything new on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant