Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Reqwest as an underlying client #106

Closed
blind-oracle opened this issue Jun 3, 2024 · 5 comments
Closed

Support Reqwest as an underlying client #106

blind-oracle opened this issue Jun 3, 2024 · 5 comments
Labels
enhancement New feature or request wontfix This will not be worked on

Comments

@blind-oracle
Copy link
Contributor

blind-oracle commented Jun 3, 2024

Current hyper-tls dependency brings OpenSSL which sucks when cross-compiling e.g. to MUSL static.
Making it depend on rustls instead would be nice somehow.

Ideally maybe we can have some generic trait like the sealed HttpClient but public and with generic Request/Response from an http crate and Body from http_body.

I can try to make a PR if that approach is acceptable.

@cole-h
Copy link
Contributor

cole-h commented Jun 4, 2024

#102 will at least make it possible to use rustls instead of openssl.

@blind-oracle
Copy link
Contributor Author

@cole-h Yeah I did that in my fork already before I saw the others :) But I guess reqwest is more mainstream since hyper is kind of hiding its clients in 1.0 release...

@loyd
Copy link
Collaborator

loyd commented Jul 11, 2024

I have a branch with hyper-v1 and rustls, but not enough tested yet. And because of #102 I need some time to figure out how I should merge these all together (or just close that PR, sorry)

@loyd
Copy link
Collaborator

loyd commented Jul 15, 2024

hyper v1 is merged in the master branch. Now, either @cole-h or I should rebase #102 (it's still easy with hyper_util::client::legacy) to finally bring rustls and release a new version.

@loyd
Copy link
Collaborator

loyd commented Jul 15, 2024

Note also, I'm not going to support the reqwest crate for now, because it's too high-level and can complicate future optimizations. Moreover, I want to have tcp+Native mode in the future.

So, I'm closing this issue.

@loyd loyd changed the title Support Reqwest as an underlying client Support rustls Jul 15, 2024
@loyd loyd changed the title Support rustls Support Reqwest as an underlying client Jul 15, 2024
@loyd loyd closed this as completed Jul 15, 2024
@loyd loyd added enhancement New feature or request wontfix This will not be worked on labels Aug 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

3 participants