Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Field Stokes shear and tendency with UniformStokesDrift #2320

Open
wants to merge 37 commits into
base: main
Choose a base branch
from

Conversation

glwagner
Copy link
Member

@glwagner glwagner commented Mar 8, 2022

This PR provides a convenience constructor for building UniformStokesDrift with four Fields for the Stokes shear and tendency, rather than functions. It also adds kernel functions for the field case, so users now have the choice between functions of (z, t), Fields, or nothing.

This is useful when calculating the Stokes profile is a relatively expensive or involved computation (eg, involving integration over a spectrum of waves). This permits two optimizations:

  1. Stationary Stokes shear profiles can be precomputed.
  2. Time-dependent Stokes shear profiles and Stokes tendencies can be computed in a Callback. This saves computation time for 3D runs because the Stokes profiles are 1D.

co-authored with @qingli411

TODO:

  • add a test

@glwagner glwagner added the feature 🌟 Something new and shiny label Mar 8, 2022
@glwagner glwagner changed the title Add convenience constructor for UniformStokesDrift with Fields Field Stokes shear and tendency with UniformStokesDrift Mar 8, 2022
@navidcy navidcy self-requested a review March 8, 2022 19:36
@glwagner
Copy link
Member Author

glwagner commented Mar 8, 2022

Thanks @navidcy for the help with this one!

@navidcy
Copy link
Collaborator

navidcy commented Mar 15, 2022

What happened here? All tests were OK and one day disaster happened...

@glwagner
Copy link
Member Author

Damn, I thought we were about to merge too

@navidcy
Copy link
Collaborator

navidcy commented Mar 16, 2022

Damn, I thought we were about to merge too

It stops at CATKEVerticalDiffusivity...

@glwagner
Copy link
Member Author

🤞

@navidcy
Copy link
Collaborator

navidcy commented Apr 20, 2022

I'm really confused with this one...

@glwagner
Copy link
Member Author

me too

@navidcy
Copy link
Collaborator

navidcy commented Jul 1, 2023

Should we close this PR? If no, could someone resolve the conflicts/

@glwagner
Copy link
Member Author

glwagner commented Jul 5, 2023

I can resolve because it should be easy.

@navidcy
Copy link
Collaborator

navidcy commented Jan 12, 2024

@glwagner should we try again for this PR?

@navidcy
Copy link
Collaborator

navidcy commented Feb 3, 2025

All tests pass (for the first time!) but docs fail with Out of memory error. This error started appearing in all CI........

@glwagner
Copy link
Member Author

glwagner commented Feb 3, 2025

All tests pass (for the first time!) but docs fail with Out of memory error. This error started appearing in all CI........

I think the fix is just to re-run. Maybe we need to reduce the number of agents on tartarus so there aren't so many builds running at the same time. We have a ton of PRs open I guess.

@glwagner
Copy link
Member Author

glwagner commented Feb 3, 2025

Another solution could be add a tag similar to what we have on ClimaOcean where the documentation is only built when we want it to.

@navidcy
Copy link
Collaborator

navidcy commented Feb 3, 2025

I tried rerunning several times…
I also tried to be mindful to not have a lot of PRs running their CI the same time. Nothing came to fruition.. I’ll try again.

@navidcy
Copy link
Collaborator

navidcy commented Feb 3, 2025

Another solution could be add a tag similar to what we have on ClimaOcean where the documentation is only built when we want it to.

I don’t really like this solution. Let’s see if we can avoid it.

@navidcy
Copy link
Collaborator

navidcy commented Feb 3, 2025

Another solution could be add a tag similar to what we have on ClimaOcean where the documentation is only built when we want it to.

The out of memory errors appear everywhere btw. Not only in docs build.

https://buildkite.com/clima/oceananigans/builds/20430#0194cd33-3e4f-49ca-abc1-9cc36b428559/28-510

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature 🌟 Something new and shiny
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants