-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Field
Stokes shear and tendency with UniformStokesDrift
#2320
base: main
Are you sure you want to change the base?
Conversation
UniformStokesDrift
with Field
sField
Stokes shear and tendency with UniformStokesDrift
Thanks @navidcy for the help with this one! |
What happened here? All tests were OK and one day disaster happened... |
Damn, I thought we were about to merge too |
It stops at |
🤞 |
I'm really confused with this one... |
me too |
Should we close this PR? If no, could someone resolve the conflicts/ |
I can resolve because it should be easy. |
@glwagner should we try again for this PR? |
All tests pass (for the first time!) but docs fail with |
I think the fix is just to re-run. Maybe we need to reduce the number of agents on tartarus so there aren't so many builds running at the same time. We have a ton of PRs open I guess. |
Another solution could be add a tag similar to what we have on ClimaOcean where the documentation is only built when we want it to. |
I tried rerunning several times… |
I don’t really like this solution. Let’s see if we can avoid it. |
The out of memory errors appear everywhere btw. Not only in docs build. https://buildkite.com/clima/oceananigans/builds/20430#0194cd33-3e4f-49ca-abc1-9cc36b428559/28-510 |
This PR provides a convenience constructor for building
UniformStokesDrift
with fourField
s for the Stokes shear and tendency, rather than functions. It also adds kernel functions for the field case, so users now have the choice between functions of(z, t)
,Field
s, ornothing
.This is useful when calculating the Stokes profile is a relatively expensive or involved computation (eg, involving integration over a spectrum of waves). This permits two optimizations:
Callback
. This saves computation time for 3D runs because the Stokes profiles are 1D.co-authored with @qingli411
TODO: