Skip to content
This repository has been archived by the owner on Jun 19, 2019. It is now read-only.

Crashes when applying styles while the controller is dismissing #109

Open
drinking opened this issue Nov 9, 2015 · 2 comments
Open

Crashes when applying styles while the controller is dismissing #109

drinking opened this issue Nov 9, 2015 · 2 comments
Assignees

Comments

@drinking
Copy link

drinking commented Nov 9, 2015

When a controller is dismissing and rotating at the same time, In some conditions it will crash.
I guess it depends on the sequence of updating style and releasing the view.

e6921743-f016-4f0e-b6df-583e816b17ee

@mikeger
Copy link
Contributor

mikeger commented Dec 22, 2015

Hey, thanks for reporting. The bug is connected to the fact that cas_parent or cas_alternativeParent is assign and it contains the reference to the deallocated object instance, I actually have a fix for that making it weak

@mikeger mikeger self-assigned this Dec 22, 2015
@atsepkov
Copy link

atsepkov commented Apr 2, 2016

Is this not the same fix as committed here: https://github.com/ClassyKit/Classy/pull/97/commits?

I too am seeing a similar crash, although in different part of the code when switching between controllers:
screen shot 2016-04-01 at 9 26 59 pm

For me, I think the problem is that the Podspec (mentioning 0.2.4 version, which is back from 2014: https://github.com/ClassyKit/Classy/blob/master/Classy.podspec) is stale, and my local version keeps thinking it's the latest even though this fix wasn't submitted until 2015. My local version, for example, is missing Classy/Reflection/CASAssociatedObjectsWeakWrapper.m which was added with that pull request.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants