Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable mypy in our pre-commit settings #1372

Open
brylie opened this issue Oct 4, 2022 · 5 comments
Open

Enable mypy in our pre-commit settings #1372

brylie opened this issue Oct 4, 2022 · 5 comments
Assignees
Labels

Comments

@brylie
Copy link
Member

brylie commented Oct 4, 2022

Idea summary

Continued from #1331

Further details

Enable mypy in our pre-commit settings by adding mirrors-mypy.

@Anuj-Kumar-AJ
Copy link
Contributor

hi @brylie, I want work for fixing on this issue, can you assign it to me.

@brylie
Copy link
Member Author

brylie commented Oct 4, 2022

Hei @Anuj-Kumar-AJ. Let's experiment with mypy-pre commit. We may need to configure Django-stubs, so we get fewer type errors.

@Anuj-Kumar-AJ
Copy link
Contributor

Hi @brylie , sorry for the delay . It was my first PR , anyways
I have send PR for this issue.

c155a35

@owenwu811
Copy link

  1. pip install pre-commit
  2. pre-commit install
    Optional:
  3. pre-commit run --all-files

@IveeDev
Copy link

IveeDev commented Sep 11, 2024

Hi! @brylie, I noticed this issue is still open, and I’d like to help if more work is needed. Could you let me know the current status and whether I can assist in completing this? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants