CI should submit a PR not merge to master with nightly script

[comountainclimber]

Due to the impact of updating tokenList.json (neon-wallet depends on it) I propose that the nightly updates submit a PR against master rather than updating it without our approval. I noticed today that the data structure being returned from https://notifications.neeeo.org/v1/tokens completely changed (please see tokenList.json to see the huge difference). Luckily I turned off nightly updates completely but this is a perfect example of how a PR would be much better than blasting away master every night

[mhuggins]

There might be a little confusion here, as tokenList.json isn't a direct reflection of the neeeo.org API endpoint. It simply uses the list of tokens from there before fetching data from the RPC servers.

[mhuggins]

But I agree that submitting a PR is a less hardhanded solution here.

[comountainclimber]

You are totally right the data structure is the same... Regardless I think submitting a PR is the safest option here

[comountainclimber]

One potential solution I thought of was to keep everything as is but always merge into a develop branch rather than directly to master it would be the job of coz to cut the PR and merge into master but CI would never directly merge to master without us reviewing the diff

[mhuggins]

Another possible solution here would be to never push if the size of the token list decreases. The only consideration is if something is added to the blacklist.