-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: Portfolio initialised with header and footer #2
base: main
Are you sure you want to change the base?
Conversation
Can you also attach screenshots? Thanks |
Also, regarding the different components, there should be a reason to put them, what do you propose is the overall purpose of this readme? |
The readme should showcase and give a brief idea to new contributors or visitors about what This is my opinion would like to know what the core team wants me to include. We can even keep it simple with just the header and footer as I have made as of now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Please see the changes
- Change all the types of
https://github.com/Aniket762/.github/blob/main/assets/youtube.svg
links from the Readme and link them with local references with this repo
Good work @Aniket762 🎉
|
||
<p align="center">Get in touch</p> | ||
<p align="center"> | ||
<a href="mailto:"><img alt="email_logo" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<a href="mailto:"><img alt="email_logo" | |
<a href="mailto: [email protected]"><img alt="email_logo" |
<p align="center">Get in touch</p> | ||
<p align="center"> | ||
<a href="mailto:"><img alt="email_logo" | ||
src="https://github.com/Aniket762/.github/blob/main/assets/email.svg"></a> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please change this and other file src's below, from your own account to relative local paths of svgs of this repository
<a href=""><img alt="slack_logo" | ||
src="https://github.com/Aniket762/.github/blob/main/assets/slack.svg"></a> | ||
| ||
<a href="https://twitter.com/layer5"><img alt="twitter_logo" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<a href="https://twitter.com/layer5"><img alt="twitter_logo" | |
<a href="https://twitter.com/CircuitVerse"><img alt="twitter_logo" |
<a href=""><img alt="github_logo" | ||
src="https://github.com/Aniket762/.github/blob/main/assets/github.svg"></a> | ||
| ||
<a href=""><img alt="linkedIn_logo" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<a href=""><img alt="linkedIn_logo" | |
<a href="https://www.linkedin.com/company/circuitverse"><img alt="linkedIn_logo" |
<a href="https://twitter.com/layer5"><img alt="twitter_logo" | ||
src="https://github.com/Aniket762/.github/blob/main/assets/twitter.svg"></a> | ||
| ||
<a href=""><img alt="github_logo" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<a href=""><img alt="github_logo" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove the Github logo as it will be shown in the GitHub itself
src="https://github.com/Aniket762/.github/blob/main/assets/twitter.svg"></a> | ||
| ||
<a href=""><img alt="github_logo" | ||
src="https://github.com/Aniket762/.github/blob/main/assets/github.svg"></a> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
src="https://github.com/Aniket762/.github/blob/main/assets/github.svg"></a> |
| ||
<a href=""><img alt="github_logo" | ||
src="https://github.com/Aniket762/.github/blob/main/assets/github.svg"></a> | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
<a href=""><img alt="linkedIn_logo" | ||
src="https://github.com/Aniket762/.github/blob/main/assets/linkedIn.svg"></a> | ||
| ||
<a href=""><img alt="youtube_logo" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<a href=""><img alt="youtube_logo" | |
<a href="https://www.youtube.com/channel/UCAK48dCPc_QON6Y5QqqRLOg"><img alt="youtube_logo" |
Hey there, I have initialized the readme with a header with CircuitVerse banner, tagline, and description while the footer contains various social media icons. Before moving forward I wanted to know your opinion!
I was curious on what are the other components which I should add, things I have in my mind:
These are the things I was thinking of adding, before I move forward I wanted to clarify if my thought process goes along the community.
Another doubt, should I include emojis in the readme? 🙈
fixes #1