Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make docker-compose.yml parametric with env variables. #67

Closed
Tracked by #90
ChakshuGautam opened this issue May 1, 2023 · 4 comments
Closed
Tracked by #90

Make docker-compose.yml parametric with env variables. #67

ChakshuGautam opened this issue May 1, 2023 · 4 comments
Labels
good first issue Good for newcomers

Comments

@ChakshuGautam
Copy link
Owner

ChakshuGautam commented May 1, 2023 •
edited
Loading

Currently the docker-compose.yaml exposes secrets for a DB. Remove that and move those to an env file.
@techsavvyash techsavvyash mentioned this issue May 15, 2023
Open
19 tasks
@techsavvyash techsavvyash added the good first issue Good for newcomers label May 24, 2023
@Midas847
Copy link

Hey , I made a PR for this issue #114

@Deekshithrathod
Copy link
Contributor

Is the Issue still open?

@Deekshithrathod Deekshithrathod mentioned this issue Jul 7, 2023
Merged
1 task
@Deekshithrathod
Copy link
Contributor

@techsavvyash raised a PR for this, can you take a look at it?

techsavvyash pushed a commit that referenced this issue Aug 1, 2023
@Deekshithrathod
moved postgres DB credentials to .env file addressing issue #67 (#140)
710beb0 
* moved postgres DB credentials to .env file

* updated GHA

---------

Co-authored-by: deekshith <[email protected]>
@techsavvyash
Copy link
Collaborator

#140 fixes this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ChakshuGautam @Midas847 @techsavvyash @Deekshithrathod