Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use v2 candidate receipts in parachain subsystems #4440

Open
1 task
axaysagathiya opened this issue Jan 8, 2025 · 0 comments
Open
1 task

Use v2 candidate receipts in parachain subsystems #4440

axaysagathiya opened this issue Jan 8, 2025 · 0 comments
Labels
S-subsystems-common T-implementation this issue/pr is a new feature or functionality.

Comments

@axaysagathiya
Copy link
Contributor

axaysagathiya commented Jan 8, 2025

Issue summary

use v2 of candidate receipt in parachain subsystems: Availability subsystem, Candidate validation subsystem, Candidate backing subsystem

Implementation details

add CandidateReceiptV2 and CommittedCandidateReceiptV2 types and use these types

type CandidateReceiptV2 struct {
	// The descriptor of the candidate.
	Descriptor CandidateDescriptorV2 
	// The hash of the encoded commitments made as a result of candidate execution.
	CommitmentsHash common.Hash
}

type CommittedCandidateReceiptV2 struct {
	// The candidate descriptor.
	Descriptor CandidateDescriptorV2
	// The commitments made by the parachain.
	Commitments CandidateCommitments
}

CandidateDescriptorV2 is already present.

As we want to update the code to use V2 of CandidateDescriptor, CandidateReceipt, and CommittedCandidateReceipt, many unit tests will be modified.

Acceptance criteria

  • Make sure all unit tests pass
@axaysagathiya axaysagathiya added T-implementation this issue/pr is a new feature or functionality. T-enhancement this issue/pr covers improvement of existing functionality. and removed T-implementation this issue/pr is a new feature or functionality. T-enhancement this issue/pr covers improvement of existing functionality. labels Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-subsystems-common T-implementation this issue/pr is a new feature or functionality.
Projects
None yet
Development

No branches or pull requests

1 participant