Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to metrics generator pattern #225

Closed
wemeetagain opened this issue Nov 11, 2022 · 0 comments · Fixed by #233
Closed

Switch to metrics generator pattern #225

wemeetagain opened this issue Nov 11, 2022 · 0 comments · Fixed by #233

Comments

@wemeetagain
Copy link
Member

See ChainSafe/lodestar#4737 (comment)
This library should be able to register its own metrics rather than rely on consumer to register its metrics.

As a rough example see: libp2p/js-libp2p-tcp#223
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat!: switch to metrics generator pattern ChainSafe/discv5
1 participant
@wemeetagain