Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New body class for landers / rovers #2020

Open
375gnu opened this issue Dec 19, 2023 · 0 comments
Open

New body class for landers / rovers #2020

375gnu opened this issue Dec 19, 2023 · 0 comments
Labels
enhancement New feature or request question Further information is requested

Comments

@375gnu
Copy link
Collaborator

375gnu commented Dec 19, 2023

Currently we use spacecraft class for Landers and/or rovers, so it's requires additional steps to detect if they are placed on surface or in space (we can use distance between them and the parent body to guess). Currently Celestia treats all spacecraft as space bodies, it even assigns orbits to stationary objects.

Why this is a problem? Celestia is a GL2 application, so unlike modern applications which use reverse logarithmic depth to increase its precision Celestia splits the depth into several intervals according to object distance. So it can put the planet and a visible rover into different depth intervals and then this can cause rendering artifacts, such as #542.

If we know that the particular object is placed on the planet surface we know that it should use the same depth interval. We also should change the way we render closer planets (render from eye instead of from center) to reduce precision errors.

Maybe other alternatives exist?

@375gnu 375gnu added enhancement New feature or request question Further information is requested labels Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant