Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why is DS4 unstable? #8

Open
saidsay-so opened this issue Aug 8, 2023 · 4 comments
Open

Why is DS4 unstable? #8

saidsay-so opened this issue Aug 8, 2023 · 4 comments

Comments

@saidsay-so
Copy link

saidsay-so commented Aug 8, 2023

Hi, thanks for your crate which is really helpful for my case!
I wanted to know why is the DualShock4 code considered unstable, and if there is a particular reason why the extended report code is still commented out?

@CasualX
Copy link
Owner

CasualX commented Aug 9, 2023

It's unstable because I never ended up needing a virtual dualshock4. Without practical experience I am not convinced that I've made the right API choices so I compromised by including some of the code but under a feature called unstable to indicate I might change the API (breaking) if I felt like it. That's all really.

@saidsay-so
Copy link
Author

saidsay-so commented Aug 9, 2023

Do you plan to work on it sometime, or otherwise, will you accept to review a PR (#10) to add the DualShock4 support? I've started something on my side since I needed it.

@CasualX
Copy link
Owner

CasualX commented Aug 9, 2023

Yeah I don't mind reviewing your work so it can be included! Right now I'm a bit confused as you have 2 PRs, should I still look at #9 ?

@saidsay-so
Copy link
Author

Oh yes, the other (#10) does not only add support for extended reports but also provides an API to build reports, with butttons and status handling, while #9 only adds support for extended reports. I can close #9 to focus on #10.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants