Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gauge tests and tests for a second gas. Also finish off documentation. #116

Open
JSegrave-IBM opened this issue Sep 28, 2020 · 3 comments
Assignees

Comments

@JSegrave-IBM
Copy link
Collaborator

JSegrave-IBM commented Sep 28, 2020

Add gauge tests and tests for a second gas.

  1. Previously, the tests only tested the TWA exposure calculations, not the comparison of those exposures to the corresponding limits - i.e. the limit 'gauge' percentages. This change adds those tests.
  2. Previously, the tests only tested one gas - carbon monoxide. This change adds tests for nitrogen dioxide as well. We don't have real nitrogen dioxide data yet, so it's mocked up data.

Additional changes to support these tests:
3. Added gas-specific rounding factors as carbon monoxide and nitrogen dioxide have different ranges.
4. Added the ability to let the tests override the windows & limits configurations, as the test results are all tied to a specific configuration.
5. Added CAL-OSHA, NIOSH and AEGL-2 example configurations to show how configuration might differ for other geographical regions, such as the NIOSH/ACGIH, CAL-OSHA or AEGL-2. This also facilitated confirming that the tests should fail (and do) when the wrong configuration is used.
6. Finished off outstanding documentation and dealt with most of the TODO's.
7. Modified DB field names to make them less sensitive to configuration changes. Fields for the different time-window TWAs are now named the after the number of minutes in that window (stable) and not by the display name (less stable and prone to SQL issues).

@JSegrave-IBM JSegrave-IBM self-assigned this Sep 28, 2020
@JSegrave-IBM JSegrave-IBM changed the title Add gas-specific rounding factors and example configurations for CAL-OSHA, NIOSH and AEGL-2 Add gas-specific rounding factors, tests for a second gas and example configurations for CAL-OSHA, NIOSH and AEGL-2 Sep 28, 2020
@JSegrave-IBM JSegrave-IBM changed the title Add gas-specific rounding factors, tests for a second gas and example configurations for CAL-OSHA, NIOSH and AEGL-2 Add gas-specific rounding factors, tests for a second gas, gauge tests, and example configurations for CAL-OSHA, NIOSH and AEGL-2 Sep 28, 2020
@JSegrave-IBM JSegrave-IBM changed the title Add gas-specific rounding factors, tests for a second gas, gauge tests, and example configurations for CAL-OSHA, NIOSH and AEGL-2 Add gauge tests and tests for a second gas. Also includes gas-specific rounding factors, and example configurations for CAL-OSHA, NIOSH and AEGL-2 Sep 28, 2020
@JSegrave-IBM JSegrave-IBM changed the title Add gauge tests and tests for a second gas. Also includes gas-specific rounding factors, and example configurations for CAL-OSHA, NIOSH and AEGL-2 Add gauge tests and tests for a second gas. Also finish off documentation. Sep 29, 2020
@JSegrave-IBM
Copy link
Collaborator Author

@JSegrave-IBM
Copy link
Collaborator Author

JSegrave-IBM commented Oct 1, 2020

@lidderupk - I added the DB field name change to this issue & associated PR.

  1. Modified DB field names to make them less sensitive to configuration changes. Fields for the different time-window TWAs are now named the after the number of minutes in that window (stable) and not by the display name (less stable and prone to SQL issues).

@JSegrave-IBM
Copy link
Collaborator Author

Dependent on:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant