Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Imports are added for unknown types #32

Open
williewillus opened this issue Aug 12, 2020 · 1 comment
Open

Imports are added for unknown types #32

williewillus opened this issue Aug 12, 2020 · 1 comment

Comments

@williewillus
Copy link

williewillus commented Aug 12, 2020

From FabricMC/fabric-loom#255

I'm working on porting a certain tech mod to Fabric from Forge, which means a few platform class names are errored out/not available in the environment.

Today, I used migrateMappings to move the in-progress port from 1.16.1+build.20 to 1.16.2+build.1. It went mostly smoothly, except that the task added imports for all the unknown forge classes. The old forge import lines had already been deleted by a regex earlier.

import vazkii.botania.api.mana.IManaReceiver;
import vazkii.botania.common.block.tile.ModTiles;
import vazkii.botania.common.block.tile.TileMod;
import IEnergyStorage; // <-- ???
import LazyOptional; // <-- ???
import javax.annotation.Nonnull;
import javax.annotation.Nullable;

likely related to #16

@jamierocks
Copy link
Member

While on a cursory glance, it may seem related to #16 - this bug only occurs when using graceful classpath checks (I would assume, Fabric actually uses a dated fork).

Though, the solutions may be the same - I think @phase was looking into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants