Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving the Visualize attribute #91

Open
valkyrienyanko opened this issue Sep 21, 2024 · 1 comment
Open

Improving the Visualize attribute #91

valkyrienyanko opened this issue Sep 21, 2024 · 1 comment

Comments

@valkyrienyanko
Copy link
Contributor

Visualize cannot visualize Dictionaries in realtime

Steps to Reproduce

  1. Add following code
[Visualize(nameof(SomeDict))]
public partial class Node2D // position this node in the world somewhere where you will see it
{
    public Dictionary<int, string> SomeDict { get; set; } = new();

    // Update SomeDict somewhere in _Process or something
}

Side note that is unrelated to this issue: There is no way to tell visualize to position a visual panel that does not extend from Node2D or Control to a manual position while at the same time visualizing a member in realtime.

Visualize messages are not all colorized

There should be a public static util method(s) specifically made for handling visualize messages. As an added bonus this could be hooked into the thread safe logger class.

Visualize cannot see values of private members from inherited classes

Have a look at this commit 706e60d

Steps to Reproduce Issue:

  1. Set _curState access modifier from protected to private
  2. Remove [Visualize] attribute from EnemyComponent
  3. Run the game
  4. Notice how you cannot see _curState for EnemyComponents even though EntityComponent has the visualize attribute listening to the _curState field
  5. You will get the following message in console: "[Visualize] Tracking 'EntityComponent' to see if '_curState' value changes"

Where would one define settings for Visualize that can easily be edited by the developer?

For example I want to add a setting to disable visualization of underscores in private fields.

Should the underscores in private fields be visible in-game?

Control Elements are not all perfectely aligned

Untitled

Add support for Godot.Collections.Array and Godot.Collections.Dictionary

@valkyrienyanko
Copy link
Contributor Author

Visualize code is so poorly written I'm thinking it should be remade from scratch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant