Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Returning ncfiles attribute in data array using getvar should be optional #314

Open
aidanheerdegen opened this issue Jan 11, 2023 · 0 comments

Comments

@aidanheerdegen
Copy link
Collaborator

PR #265 added an ncfiles attribute to the DataArray returned by getvar. This attribtue is a list of all the netcdf files that are queried to create the DataArray, and from which data could be extracted when the data is accessed.

This is useful information to the user, but by default it makes for very verbose output in jupyter notebooks when a the DataArray is "printed" in the code block.

In retrospect it was a mistake to return ncfiles as an attribute by default. I think this should be wound back, and the functionality retained, but requiring an option to getvar, e.g. ncfilesattr = True or similar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant