Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WOMBAT: issue with units of ice-to-ocean algae and nitrate fluxes #282

Open
dougiesquire opened this issue Apr 23, 2024 · 34 comments
Open
Labels

Comments

@dougiesquire
Copy link

dougiesquire commented Apr 23, 2024

In MOM5, the units of the prognostic tracer stf field (surface tracer flux) should be "rho * m/s * tracer conc". E.g., WOMBAT prognostic tracers carry units of xmol/m3 (x=m for all tracers except iron which has x=u), so their stf units should be kg*xmol/m5/s. This is the case for DIC, aDIC, O2 and iron (I think, though the provenance of the dust.nc input file is unknown).

However, phytoplankton and nitrate surface tracer fluxes are set directly to the ice-to-ocean algae and nitrate fluxes received from the coupler, which I think have units of mmol/m2/s. I think these fields should be multiplied by rho0. I.e. the surface fluxes are approximately ~1000 too small at the moment.

@pearseb
Copy link

pearseb commented Apr 23, 2024

That's a good catch Dougie. I really haven't looked closely at these fluxes at all, but I know that there is a lot of room for improvement here.

pearse

@aekiss
Copy link
Contributor

aekiss commented Apr 23, 2024

ping @hakaseh

@hakaseh
Copy link
Collaborator

hakaseh commented May 14, 2024

I had a quick look and I agree that I had assumed incorrect units for those fluxes, as mmol/m2/s.
I had noticed in the past that these ice-to-ocean fluxes had negligible effects on surface ocean phy or no3 and now it makes sense why. Thanks @dougiesquire for careful check.
Should I fix this?

@aekiss
Copy link
Contributor

aekiss commented May 15, 2024

Is this error only in the ice->ocean flux or also in the ocean->ice flux?

@aekiss
Copy link
Contributor

aekiss commented May 15, 2024

Should density be rho0 or ice density? rho0 seems right to me, but I thought I should ask.

@dougiesquire
Copy link
Author

Should density be rho0 or ice density? rho0 seems right to me, but I thought I should ask.

Yeah I think rho0. That's what's done for the other surface flux terms in WOMBAT.

@dougiesquire
Copy link
Author

Is this error only in the ice->ocean flux or also in the ocean->ice flux?

Sea surface concentration of nitrate and phytoplankton in mmol/m^3 are passed back to the ice (see here and here). This looks correct.

@dougiesquire
Copy link
Author

dougiesquire commented May 15, 2024

Should I fix this?

@hakaseh, if you have time to submit a PR that would be welcome. I'd be happy to review.

@aekiss
Copy link
Contributor

aekiss commented May 15, 2024

Is this error only in the ice->ocean flux or also in the ocean->ice flux?

Sea surface concentration of nitrate and phytoplankton in mmol/m^3 are passed back to the ice (see here and here). This looks correct.

Hm, so exchange with sea ice acts as a sink of ocean nutrient and phyto, since 99.9% of it won't come back to the ocean (if we neglect productivity in the ice).

@dougiesquire
Copy link
Author

dougiesquire commented May 15, 2024

Hm, so exchange with sea ice acts as a sink of ocean nutrient and phyto, since 99.9% of it won't come back to the ocean (if we neglect productivity in the ice).

I may be misunderstanding, but I don't think the ice removes any nitrate/phytoplankton from the ocean. An amount 1000 times too small is fluxed into the ocean from the ice, but nothing is fluxed out. I'm not sure what happens on the CICE side.

@pearseb
Copy link

pearseb commented May 16, 2024 via email

@aekiss
Copy link
Contributor

aekiss commented May 16, 2024

Ocean nutrient and phyto is coupled to ice (as well as the reverse) https://github.com/COSIMA/1deg_jra55_ryf/blob/0d412448f6ff5a4ce74987e3e8e0d20d3043334b/namcouple#L322-L331

@ofa001
Copy link

ofa001 commented May 16, 2024

@aekiss that suggests that the correction needs to be applied both ways, if it was in error that way too.

@anton-seaice
Copy link

Hm, so exchange with sea ice acts as a sink of ocean nutrient and phyto, since 99.9% of it won't come back to the ocean (if we neglect productivity in the ice).

Does this mean it accumulates in an unrealistic way in the sea-ice? Possibly not because the sea-ice will melt and so the nutrient/phyto disappears over summer?

@aekiss
Copy link
Contributor

aekiss commented May 16, 2024

What I was wondering is if 1 mol (of N or phy) from the ocean arrives as 1 mol in ice, then when it returns to the ocean does that 1 mol in the ice becomes 0.001 mol in the ocean? So the round trip makes 99.9% of N or phy disappear?

@aekiss
Copy link
Contributor

aekiss commented May 16, 2024

If so, it's actually worse to have the error only in the ice->ocean coupling (not ocean -> ice), because then it acts as a sink of N & phy from the ocean.

@dougiesquire
Copy link
Author

Okay I'm a bit confused by some of the discussion here and I think I must be missing something. Looking at the code, what I see happening from the ocean's perspective is:

  • the ocean receives surface fluxes of N & phy from the ice
  • WOMBAT runs and the surface fluxes are included when calculating the new surface concentrations of N & phy
  • the surface concentrations of N & phy are passed back to the ice

If the surface fluxes are 1000x too small, isn't this effectively like having no coupling of N & phy from the ocean's perspective? What am I missing?

@pearseb
Copy link

pearseb commented May 16, 2024

Dougie is there a loss of N and Phy when the ocean passes these terms to the ice?

@dougiesquire
Copy link
Author

dougiesquire commented May 16, 2024

Dougie is there a loss of N and Phy when the ocean passes these terms to the ice?

If there is, I can't see it. All that's passed to the ice is the surface concentration at the end of the ocean timestep.

@aekiss
Copy link
Contributor

aekiss commented May 16, 2024

Ah yes, apologies for the red herring, I think you're right @dougiesquire. According to the comments in namcouple, the coupler sends surface concentrations (not fluxes) from mom to cice, and the fluxes are only from cice to mom. Sorry I didn't look more carefully.

@dougiesquire
Copy link
Author

dougiesquire commented May 16, 2024

From the ice's perspective on the other hand, it fluxes N & phy to the ocean but doesn't see what it sent reflected in the concentrations that are returned.

@pearseb
Copy link

pearseb commented May 16, 2024

Hmmm... So the coupling wasn't a complete coupling. If there wasn't an error in units by 1e-3 then the sea ice would be adding substantial quantities of nitrogen and phytoplankton to the ocean without there being a opposing sink of these fields. We should revisit this in the future and make the coupling complete.

@aekiss
Copy link
Contributor

aekiss commented May 16, 2024

doesn't see what it sent reflected in the concentrations that are returned

(or only sees it reflected at 0.1% the level it should be)

@aekiss
Copy link
Contributor

aekiss commented May 16, 2024

Should there also be an atmospheric dust input of nutrient to the ice? Or is that insignificant?

@dougiesquire
Copy link
Author

Hmmm... So the coupling wasn't a complete coupling. If there wasn't an error in units by 1e-3 then the sea ice would be adding substantial quantities of nitrogen and phytoplankton to the ocean without there being a opposing sink of these fields. We should revisit this in the future and make the coupling complete.

I'm not sure about this. The ice decides how much N & phy should be fluxed between the ice and ocean based on the surface concentrations. The ocean updates the surface concentrations based on those fluxes (and other things) and the process repeats. The fluxes can presumably go negative so the ice can take N & phy from the ocean.

@dougiesquire
Copy link
Author

Should there also be an atmospheric dust input of nutrient to the ice? Or is that insignificant?

I'm not sure, but relatedly the flux of atmospheric dust to the ocean does not get modified by sea ice.

@pearseb
Copy link

pearseb commented May 17, 2024

Wait so there are fluxes? This is getting a bit confusing to be honest.

RE ice and dust: Yes, the ice does accumulate important quantities of dust, with particular relevance for iron fluxes to surface waters during the melt period. This is something that we should look into.

@anton-seaice
Copy link

@pwongpan - we're not sure how the ice-to-ocean (and back) fluxes for phytoplankton and nitrate surface tracer fluxes are calculated. They are calculated within CICE, but we are not sure what process that represents (e.g. is it only associated with freeze/melt, or is it something else?)

@hakaseh
Copy link
Collaborator

hakaseh commented May 17, 2024

I will have a closer look at the code next week to recall how I did the two way coupling.

@ofa001
Copy link

ofa001 commented May 17, 2024

@PearceB and @pwongpan Cice does handle dust, as does Wombat, but I think you told me it was just a climatology, you can pass a dust variable from the UM if we want to think of coupling to there as well. But then I think we need tothink of whether this is "the CICE5 set up like @hakaseh used, what we want to potentially use in CICE6-MOM6 where mushy is an option (though not when couple dot the UM) or when in the older CICE version in ESM1.6 which still uses CICE4.1 which wont be able handle anything more sophisticated ice BGC wise that in CICE5 (we have to use the zero layer version of the thermodynamics there as well.

@hakaseh
Copy link
Collaborator

hakaseh commented May 28, 2024

Sorry for the late reply (I'm attending JpGU this week).

I am not sure if I understand the issues here except for the incorrect units for ice-to-ocean flux, but I am guessing there are some questions about whether tracer concentration in sea ice is updated according to the ice-ocean flux?
In CICE5, tracer concentration in sea ice is updated in subroutine skl_biogeochemistry.
The ice-ocean flux is determined based on melting/growth rate of sea ice which is done here.

@dougiesquire
Copy link
Author

dougiesquire commented May 28, 2024

I am not sure if I understand the issues here except for the incorrect units for ice-to-ocean flux

Thanks @hakaseh. I don't think there are any other issues - just some communication breakdown.

In CICE5, tracer concentration in sea ice is updated in subroutine skl_biogeochemistry.
The ice-ocean flux is determined based on melting/growth rate of sea ice which is done here.

Thanks for checking this and clarifying

@access-hive-bot
Copy link

This issue has been mentioned on ACCESS Hive Community Forum. There might be relevant details there:

https://forum.access-hive.org.au/t/cosima-twg-meeting-minutes-2024/1734/10

@access-hive-bot
Copy link

This issue has been mentioned on ACCESS Hive Community Forum. There might be relevant details there:

https://forum.access-hive.org.au/t/access-om2-release-information/1602/4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

7 participants