-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
_dist
in Meaning
: either make tuple
or eliminate
#31
Comments
Ah, I tend towards making it a tuple. I had similar thought process when recently working on the recent hashability issues but for whatever reason forgot to implement. And yeah, while I think letting a Meaning encode the literal distribution over referents for its expression is clearly an important distinction from the prior ( e.g., color names), we haven't had a use case for this yet since the research ultk supports mainly assumes that every referent is equally, for each Expression/Meaning. But it's nice to have since much of the effcomm research does not make this assumption. |
Yeah, I totally agree that hard-coding the uniform distribution is the "worst" solution. So I think the options are (i) |
Oh, I see. What does it mean to initialize according to self.universe.prior? To take only the subset of probabilities from the universe prior corresponding to the Meaning.referents, and then renormalize? |
This commit has the tuple implementation, but defaults to the uniform distribution. N.B.: the current modals implementation and indefinites example results assume the uniform distribution even if that is the 'worst', so maybe I'd add a kwarg for uniform initialization to replicate that behavior if we chose not to uniform initialize meanings by default |
After further consideration we have decided to explore letting _dist be a frozenset of (Referent, float) tuples. See #33 |
_dist
inMeaning
is still a dict. I thought about quickly changing it to a tuple, but wanted to discuss another possibility: just eliminating it all together. AMeaning
still has aUniverse
, which itself has aprior
, so we can get a distribution for theMeaning
from theUniverse
s. Are there situations where we want theMeaning
to be a distribution that comes from some other source than this?The text was updated successfully, but these errors were encountered: