Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make git commit and branch name tracking work outside of github actions #249

Open
damonbayer opened this issue Dec 16, 2024 · 0 comments
Open

Comments

@damonbayer
Copy link
Collaborator

damonbayer commented Dec 16, 2024

          should this and the branch name be arguments to the container build call or should the container build engine itself invoke `git` to determine it? The latter seems more robust: will also work with local builds, will reduce GH actions magic, and it's a pretty minimal dep for container building.

Originally posted by @dylanhmorris in #242 (comment)

Either copy the .git directory into the container so that the python code just works (better option) or use something like ENV GIT_COMMIT=$(git rev-parse HEAD) in the Containerfile.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant