Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up env vars #165

Open
Tracked by #182
zsusswein opened this issue Jan 21, 2025 · 0 comments
Open
Tracked by #182

Clean up env vars #165

zsusswein opened this issue Jan 21, 2025 · 0 comments
Labels

Comments

@zsusswein
Copy link
Collaborator

The same environment variables have different names in the R code and the python deployment scripts. They should be updated to use the same names, ideally using the python SDK's names as canonical.

See here

az_tenant_id <- fetch_credential_from_env_var("az_tenant_id")
az_client_id <- fetch_credential_from_env_var("az_client_id")
az_service_principal <- fetch_credential_from_env_var("az_service_principal")

and here

batchmodels.EnvironmentSetting(name="az_tenant_id", value=os.environ["AZURE_TENANT_ID"]),
batchmodels.EnvironmentSetting(name="az_client_id", value=os.environ["AZURE_CLIENT_ID"]),
batchmodels.EnvironmentSetting(name="az_service_principal", value=os.environ["AZURE_CLIENT_SECRET"])

@zsusswein zsusswein mentioned this issue Jan 29, 2025
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant