Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

End-to-end test for static numbers #163

Open
Tracked by #181
zsusswein opened this issue Jan 21, 2025 · 0 comments
Open
Tracked by #181

End-to-end test for static numbers #163

zsusswein opened this issue Jan 21, 2025 · 0 comments
Labels

Comments

@zsusswein
Copy link
Collaborator

Currently we have end-to-end tests, but these are more "smoke tests" checking that the code runs all the way through. They run the sampler for only a couple of iterations and write files, so the results aren't quantitatively rigorous.

Ideally we would have a more heavyweight end-to-end test that ran only in CI. This test would run on simulated data (our gostic_toy_rt package data) and several chains and and draw a couple thousand samples. We could use this test to check for unexpected changes in the underlying model.

I think a decent check would be to run the model, check that everything was written as expected and the diagnostics are clean, and to plot the summaries vs the data and known simulated Rt. These plots could be snapshot tests through vdiffr::expect_doppelganger(). We could control the test only runs in CI with a testthat::skip_if and setting an env var in the CI environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant