Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edit Horizon for sample_fit.RDS in tests #162

Open
Tracked by #182
PatrickTCorbett opened this issue Jan 16, 2025 · 0 comments
Open
Tracked by #182

Edit Horizon for sample_fit.RDS in tests #162

PatrickTCorbett opened this issue Jan 16, 2025 · 0 comments
Labels
v0.3.0

Comments

@PatrickTCorbett
Copy link
Collaborator

Tests in this PR #144 did not catch an issue where ~ 14 rows were NA due to a faulty intermediary join that kept rows associated with future dates. The result is that tests were passed but the outputs has rows that were completely null.

Goal: edit the sample_fit.RDS used in tests and expand its horizon
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
v0.3.0
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@natemcintosh @zsusswein @PatrickTCorbett