Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release Candidate Test: March 2023 RC0 #1130

Closed
boverhof opened this issue Apr 5, 2023 · 5 comments
Closed

Release Candidate Test: March 2023 RC0 #1130

boverhof opened this issue Apr 5, 2023 · 5 comments
Assignees
Labels
Priority:Normal Normal Priority Issue or PR

Comments

@boverhof
Copy link
Member

boverhof commented Apr 5, 2023

Description

Setup

  • grabs zips from release page and install
>conda create --name ccsi-foqus -c conda-forge python=3.8 pywin32
>conda activate ccsi-foqus
>cd FOQUS-3.17.0rc0
>pip install .
@boverhof boverhof self-assigned this Apr 5, 2023
@boverhof
Copy link
Member Author

boverhof commented Apr 5, 2023

Dev

  • install dev requirements so can run tests
  • @lbianchi-lbl is this expected behavior? Tests can't be run without a GIT clone currently.
>pip install -r requirements-dev.txt

> pytest
======================================================================================== ERRORS =========================================================================================
_________________________________________________________________________ ERROR at setup of test_results_empty __________________________________________________________________________

    @pytest.fixture(scope="session")
    def _repo_root():
        this_file = Path(__file__).resolve()  # FOQUS/foqus_lib/conftest.py
        repo_root = this_file.parent.parent
>       assert (repo_root / ".git").is_dir()
E       AssertionError: assert False
E        +  where False = <bound method Path.is_dir of WindowsPath('C:/Users/Administrator/Desktop/FOQUS-3.17.0rc0/.git')>()
E        +    where <bound method Path.is_dir of WindowsPath('C:/Users/Administrator/Desktop/FOQUS-3.17.0rc0/.git')> = (WindowsPath('C:/Users/Administrator/Desktop/FOQUS-3.17.0rc0') / '.git').is_dir

foqus_lib\conftest.py:54: AssertionError

@boverhof
Copy link
Member Author

boverhof commented Apr 5, 2023

Optional Install Page Outdated

@boverhof
Copy link
Member Author

boverhof commented Apr 5, 2023

Local Flowsheet Test: BFB_OUU_06_09_2020.foqus

  • success, ran 4 times in a row
  • ccsi-foqus-3.17.0rc0-examples\examples\test_files\OUU_Remote_Turbine_BFB\BFB_OUU_06_09_2020.foqus

@lbianchi-lbl
Copy link
Contributor

Dev

* install dev requirements so can run tests

* @lbianchi-lbl is this expected behavior?  Tests can't be run without a GIT clone currently.

Yes, that's the expected (although perhaps not intended) behavior - currently running pytest is only supported for the "developer workflow", i.e. git clone + pip install requirements-dev.txt.

However, being able to run the test suite (or a subset of it) after a non-editable or non-git installation would be useful, especially in the context of testing releases. I've opened #1131 to keep track of this.

@ksbeattie ksbeattie added the Priority:Normal Normal Priority Issue or PR label Apr 11, 2023
@ksbeattie
Copy link
Member

Closing this as "done" for March, with a more complete solution tracked in #1131

ksbeattie added a commit to ksbeattie/FOQUS that referenced this issue Apr 11, 2023
Fixing broken link as described in CCSI-Toolset#1135 and CCSI-Toolset#1130
This was referenced Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:Normal Normal Priority Issue or PR
Projects
None yet
Development

No branches or pull requests

3 participants