Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests for plugin loading from string reading #1074

Closed
bpaul4 opened this issue Oct 14, 2022 · 2 comments · Fixed by #1075
Closed

Tests for plugin loading from string reading #1074

bpaul4 opened this issue Oct 14, 2022 · 2 comments · Fixed by #1075
Assignees
Labels
Priority:High High Priority Issue or PR

Comments

@bpaul4
Copy link
Contributor

bpaul4 commented Oct 14, 2022

Recently, I noticed that FOQUS is not correctly loading Pymodel plugins from the user_plugins or examples/.../pymodels folders. A recent update had run black on session.py and surrogates.py which generate the idString objects used to detect and load plugins, so that files contained black-formatted # FOQUS-[tag] while the search expected #FOQUS-[tag].

The issue went undetected until black was run on the working directory and those plugins failed to load; the console did not display any error or warning message that the idString did not properly parse. There should be tests that check that plugins are correctly loaded when FOQUS is launched, and we should add better logger messages for when this case arises.

@bpaul4 bpaul4 self-assigned this Oct 14, 2022
@lbianchi-lbl
Copy link
Contributor

Hi @bpaul4, thanks for spotting this and creating an issue.

Can I ask you to point out where exactly the files for the plugins that are failing to load are located within the FOQUS repository? I'm starting to look into this (also in relation to #908) and I'd like to make sure I'm at least aware of the existing plugins.

@bpaul4
Copy link
Contributor Author

bpaul4 commented Oct 14, 2022

These are the files that fail to load: https://github.com/CCSI-Toolset/FOQUS/tree/master/foqus_lib/framework/pymodel

@bpaul4 bpaul4 linked a pull request Oct 17, 2022 that will close this issue
@ksbeattie ksbeattie added the Priority:High High Priority Issue or PR label Oct 25, 2022
@ksbeattie ksbeattie moved this to In Progress in 2022 Sept Release Oct 25, 2022
@ksbeattie ksbeattie moved this to In Progress in 2022 Dec Release Oct 25, 2022
Repository owner moved this from In Progress to Done in 2022 Dec Release Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:High High Priority Issue or PR
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants