Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: mainnet bounty shows wrong text when logged on rinkerby #15

Open
thelostone-mc opened this issue May 24, 2018 · 2 comments
Open

bug: mainnet bounty shows wrong text when logged on rinkerby #15

thelostone-mc opened this issue May 24, 2018 · 2 comments

Comments

@thelostone-mc
Copy link

Issue

Mainnet bounty shows wrong text when logged on rinkerby network via metmask

screen shot 2018-05-24 at 5 26 28 pm

Steps to Reproduce

Login into the test net (rinkerby) via metamask and open a bounty funded on the mainnet like
https://beta.bounties.network/bounty/v1/486

Fix

Update the content to use the current active network rather than hardcoding the message

@thelostone-mc
Copy link
Author

@villanuevawill opened up the issue here ! Sorry about that

villanuevawill commented 2 hours ago
@thelostone-mc - 485 and 487 show up. This is a pretty extreme edge case where 486 does not exist on the rinkeby testnet. Most ids will exist from the mainnet that exist on rinkeby. We should def. update this, but I think there are only 3 ids that don't exist in rinkeby that exist in mainnet.

@mbeylin
Copy link
Collaborator

mbeylin commented May 24, 2018

Basically the way the Bounties Network operates is that we use whichever Ethereum network gets injected by MetaMask, whether it's MainNet or Rinkeby. A fix for this could entail us embedding the network type directly in the URL, but this would likely break our existing URL structure.

I will push a fix which changes the error message depending on the current network.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants