Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rarity of loot on multiple tables is not calculated correctly #82

Open
jack0lantern opened this issue Jul 14, 2023 · 1 comment
Open
Labels
bug Something isn't working enhancement New feature or request

Comments

@jack0lantern
Copy link

My buddy kept getting rune spear notifications from basilisk knights because the plugin thinks the rarity is 1/13312. But the item is on 2 tables, the main roll is 1/52, and then the gem table has it at 1/13312

So the rarity should actually be 1/52 + 1/13312

@iProdigy
Copy link
Contributor

Example logic to account for multiple drop rates: https://github.com/iProdigy/DinkPlugin/blob/88331ec8f35cface89444d6c4575a0e5127c439e/src/main/java/dinkplugin/util/NpcDropTable.java#L33-L40

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants