Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Models are missing face shading #148

Open
ChloeDawn opened this issue Jan 31, 2021 · 4 comments
Open

Models are missing face shading #148

ChloeDawn opened this issue Jan 31, 2021 · 4 comments

Comments

@ChloeDawn
Copy link

ChloeDawn commented Jan 31, 2021

BlueMap Version:
1.3.0-forge-1.16.2

Description:
Models rendered on the map lack directional shading on faces like is applied in Minecraft, sides being darker than the top, west/east being darker than north/south, and down being darker still.

In-game screenshot
Map screenshot

@TBlueF
Copy link
Member

TBlueF commented Jan 31, 2021

I'll test around with adding some directional shades, if i manage to make something that looks good, i'll add it :)

@TBlueF
Copy link
Member

TBlueF commented Feb 5, 2021

One problem with adding those lights is blocks like tall grass..
if i add a directional light, tall-grass-blocks start looking very dark and not like ingame at all on bluemap:

left with directional-light, right current lighting
image

@ChloeDawn
Copy link
Author

Model elements have a "shade" flag that defaults to true when absent, stuff like the grass cross model and torches set it to false. Possibly you could parse that?

@TBlueF
Copy link
Member

TBlueF commented Feb 5, 2021

Well, that however means that this is a breaking change that needs model-changes ... so it's not going to happen as soon as i thought ^^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Planned (unordered)
Development

No branches or pull requests

2 participants