-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve UX for descriptor registration #142
Comments
Many thanks. |
i think you can replace the path by wether the key is owned or not |
I just registered a descriptor here, and indeed on the keys that have a fingerprint matching this signer have an asterisk in the title bar "Signer 2/2 *". |
yes got it! |
While testing the Jade implementation in Liana wallet i notice 2 important points:
In miniscript descriptors it's forbiden to reuse a key w/ the same multipath, so in liana we change the multipath for each occurence (<0;1>, <2;3>, <4;5>, etc...) when a key is used in several conditions. Multipaths are displayed in the descriptor template while registering a descriptor on jade, that is what i expected:
but multipath are also displayed while reviewing the keys:
it is unnecessary and add a lot more in what the user need to verify, in the picture example, each key(total 4 keys) is use 3 time in the descriptor, so i have to verify 12 keys where in fact there is only 4!
the jade never notify the user which key it owns, but it should!
The text was updated successfully, but these errors were encountered: