Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve UX for descriptor registration #142

Open
pythcoiner opened this issue Jun 24, 2024 · 4 comments
Open

Improve UX for descriptor registration #142

pythcoiner opened this issue Jun 24, 2024 · 4 comments

Comments

@pythcoiner
Copy link
Contributor

While testing the Jade implementation in Liana wallet i notice 2 important points:
In miniscript descriptors it's forbiden to reuse a key w/ the same multipath, so in liana we change the multipath for each occurence (<0;1>, <2;3>, <4;5>, etc...) when a key is used in several conditions. Multipaths are displayed in the descriptor template while registering a descriptor on jade, that is what i expected:

image

but multipath are also displayed while reviewing the keys:

image

  • it is unnecessary and add a lot more in what the user need to verify, in the picture example, each key(total 4 keys) is use 3 time in the descriptor, so i have to verify 12 keys where in fact there is only 4!

  • the jade never notify the user which key it owns, but it should!

@JamieDriver
Copy link
Collaborator

  1. Point taken, yes am aware it's not ideal, will try to look into it asap

  2. Yes, should definitely highlight that in some way, agree. I think in 'multisig' it just sticks a asterisk in the title bar - will see if we can do something similar.

Many thanks.

@pythcoiner
Copy link
Contributor Author

2. Yes, should definitely highlight that in some way, agree. I think in 'multisig' it just sticks a asterisk in the title bar - will see if we can do something similar.

i think you can replace the path by wether the key is owned or not

@JamieDriver
Copy link
Collaborator

JamieDriver commented Jun 25, 2024

I just registered a descriptor here, and indeed on the keys that have a fingerprint matching this signer have an asterisk in the title bar "Signer 2/2 *".
I agree it's not the most 'striking' marker - alas the screen is so small ;-) We'll discuss what we can do to improve it internally. Just to check though, do you agree you do see this '*' for your signers ?

@pythcoiner
Copy link
Contributor Author

Just to check though, do you agree you do see this '*' for your signers ?

yes got it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants