Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme is not correctly applied on specific parts of the UI #144

Open
JMaravalhasSilva opened this issue Apr 13, 2023 · 4 comments
Open

Theme is not correctly applied on specific parts of the UI #144

JMaravalhasSilva opened this issue Apr 13, 2023 · 4 comments

Comments

@JMaravalhasSilva
Copy link

I'm running Themeify 1.2.2, Octoprint 1.8.7, and some specific parts of the UI are clearly not working as intended:

image

image

All settings at default values.

This issue appears to be somewhat similar to #118, but on different parts of the UI.

@LazeMSS
Copy link

LazeMSS commented Nov 22, 2023

I dont think this plugin is actively developed - tried contacting the developer but without any success. I have a similar plugin: https://plugins.octoprint.org/plugins/uicustomizer/ and was hoping to join forces with him.

@Birkbjo
Copy link
Owner

Birkbjo commented Nov 22, 2023

I actually spent some time last week on trying to migrate to using css-sheets for custom rules. So that should fix some of these issues. I can take a look at what you're doing and get some inspiration!

However this looks like just a missing/wrong css-rule in the theme, so can take a look at that.

@LazeMSS
Copy link

LazeMSS commented Nov 22, 2023

@Birkbjo awesome ;) I was looking into the next branch also :) I was wondering if you had left the OP project. I don't have that much time and thought maybe we could join forces and help each other.

If I really had the time I would rewrite the UI but to be honest I have started using Klipper/Mainsail.

@Birkbjo
Copy link
Owner

Birkbjo commented Nov 22, 2023

@Birkbjo awesome ;) I was looking into the next branch also :) I was wondering if you had left the OP project. I don't have that much time and thought maybe we could join forces and help each other.

If I really had the time I would rewrite the UI but to be honest I have started using Klipper/Mainsail.

I don't really have much time or motivation either, since the current version does what I need - getting a nice looking dark theme.

I'm all in for that, looked briefly through the code. But it looks way more feature rich and complicated than Themeify.

Currently I just want to improve the customization, so instead of changing html styles, I just have a stylesheet object - eg https://developer.mozilla.org/en-US/docs/Web/API/CSSStyleSheet. Ran into some issue that I couldn't have two, but I've a solution in mind.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants