Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to disable tabindex? A rect focused border is annoying #107

Open
pipoa opened this issue Feb 20, 2019 · 4 comments
Open

How to disable tabindex? A rect focused border is annoying #107

pipoa opened this issue Feb 20, 2019 · 4 comments

Comments

@pipoa
Copy link

pipoa commented Feb 20, 2019

I'm submitting a...


[ ] Bug report  
[X] Feature request

Current behavior

When click, tabindex makes rating component focused and having a rect around.

Expected behavior

show without tabindex attribute in inner Div tag

@anidotnet
Copy link

Even when the star component is clicked the blue rect comes, it is really annoying.

@Recodify
Copy link

@pipoa @anidotnet
You can remove the blue box whilst retaining the tab index (probably the desired result) by adding the following to the scss of the component which uses the star-rating:

 /deep/ star-rating div#rating {
    outline: none;
  }

@Tyler-V
Copy link

Tyler-V commented Sep 11, 2020

Noticed the same and almost walked from the demo. Should this not be part of the core package already?

It cant be a feature... its not for screen readers... so....?

@T4SUYA
Copy link

T4SUYA commented Oct 23, 2020

Just put on you styles.scss the following

.rating { outline: none; }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants