Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PDC_LOG missing/removed? #174

Open
GitMensch opened this issue Jul 7, 2020 · 2 comments
Open

PDC_LOG missing/removed? #174

GitMensch opened this issue Jul 7, 2020 · 2 comments

Comments

@GitMensch
Copy link
Collaborator

GitMensch commented Jul 7, 2020

When inspecting #172 I've recognized that this repo uses it much less than @wmcbrine's repo (which also don't use it in all methods).

Is there a reason for this?
Should all functions start with it?

@Bill-Gray
Copy link
Owner

I've used it on rare occasion. It's nice to have the capability there, for investigating particular bugs. I've added a PDC_LOG on an as-needed basis.

But for most debugging, I've used gdb. (Note that this fails with the Windows and DOS ports... at least, I've not managed to get Windows programs running under Wine to use gdb, though I gather it's possible.)

I would be willing to pull changes that involved adding PDC_LOG more widely. Such a change should be harmless and potentially helpful. But adding it is not on my list of priorities.

@GitMensch
Copy link
Collaborator Author

at least, I've not managed to get Windows programs running under Wine to use gdb, though I gather it's possible

Yes, use the gdb from mingw inside wine and you're good to go.

I would be willing to pull changes that involved adding PDC_LOG more widely.

As the initial question was about the ones that are already available upstream this is a valid answer. If they were "lost", then it wasn't done by purpose.

Ee leave this issue as "anybody pulls that in, please?"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants