Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

/is top spams "Visits are disabled in this island" #299

Closed
IAISI opened this issue Jan 1, 2024 · 1 comment · Fixed by #300
Closed

/is top spams "Visits are disabled in this island" #299

IAISI opened this issue Jan 1, 2024 · 1 comment · Fixed by #300
Assignees
@tastybento
Labels
done this has been completed Type: Bug

Comments

@IAISI
Copy link

IAISI commented Jan 1, 2024

Expected behavior

No message or message on click would be better IMO.

Observed/Actual behavior

When a player does /is top they would get spawmmed with "Visits are disabled in this island" for each island on Is Top with Visits disabled.

Steps/models to reproduce

Get island on Is Top
Disable Visits
Run /is top

BentoBox version

bbox version
[23:07:45 INFO]: Running PAPER 1.20.4.
[23:07:45 INFO]: BentoBox version: 2.0.0-SNAPSHOT-b2514
[23:07:45 INFO]: Database: JSON
[23:07:45 INFO]: Loaded Game Worlds:
[23:07:45 INFO]: bskyblock_world (BSkyBlock): Overworld, Nether, The End
[23:07:45 INFO]: Loaded Addons:
[23:07:45 INFO]: Bank 1.7.1-SNAPSHOT-b87 (ENABLED)
[23:07:45 INFO]: Biomes 2.2.0-SNAPSHOT-b255 (ENABLED)
[23:07:45 INFO]: Border 4.1.1-SNAPSHOT-b187 (ENABLED)
[23:07:45 INFO]: BSkyBlock 1.17.0-SNAPSHOT-b751 (ENABLED)
[23:07:45 INFO]: CauldronWitchery 2.1.0-SNAPSHOT-#58 (ENABLED)
[23:07:45 INFO]: Challenges 1.3.0-SNAPSHOT-b538 (ENABLED)
[23:07:45 INFO]: CheckMeOut 1.2.0-SNAPSHOT-b92 (ENABLED)
[23:07:45 INFO]: ControlPanel 1.13.1-SNAPSHOT-b61 (ENABLED)
[23:07:45 INFO]: DimensionalTrees 1.6.1-SNAPSHOT-b89 (ENABLED)
[23:07:45 INFO]: ExtraMobs 1.12 (ENABLED)
[23:07:45 INFO]: IslandFly 1.11.1 (ENABLED)
[23:07:45 INFO]: Level 2.12.0-SNAPSHOT-b553 (ENABLED)
[23:07:45 INFO]: Likes 2.4.0-SNAPSHOT-b99 (ENABLED)
[23:07:45 INFO]: MagicCobblestoneGenerator 2.6.0-SNAPSHOT-b270 (ENABLED)
[23:07:45 INFO]: TwerkingForTrees 1.4.4-SNAPSHOT-b68 (ENABLED)
[23:07:45 INFO]: Visit 1.7.0-SNAPSHOT (ENABLED)
[23:07:45 INFO]: Warps 1.14.0-SNAPSHOT-b358 (ENABLED)

Plugin list

pl
[23:08:09 INFO]: Server Plugins (37):
[23:08:09 INFO]: Paper Plugins:
[23:08:09 INFO]: - EchoPet
[23:08:09 INFO]: Bukkit Plugins:
[23:08:09 INFO]: - AdditionalFeatures, AuctionHouse, BentoBox, BentoBox-Bank, BentoBox-Biomes, BentoBox-BSkyBlock, BentoBox-CauldronWitchery, BentoBox-Challenges, BentoBox-CheckMeOut, BentoBox-IslandFly
[23:08:09 INFO]: BentoBox-Level, BentoBox-Likes, BentoBox-MagicCobblestoneGenerator, BentoBox-Visit, BentoBox-Warps, BentoBoxPlus, Citizens, CompatNoCheatPlus, Crates, FastAsyncWorldEdit
[23:08:09 INFO]: GSit, HolographicDisplays, LockettePro, LogBlock, NoCheatEnforcer, NoCheatPlus, ProtocolLib, ServerManager, ShopManager, SimpleTrading
[23:08:09 INFO]: spark, UserManager, Vault, ViaBackwards, ViaVersion, WorldGuard

Other

No response
@tastybento tastybento self-assigned this Jan 2, 2024
@tastybento tastybento transferred this issue from BentoBoxWorld/Visit Jan 2, 2024
@tastybento tastybento added in progress this is being worked on Type: Bug labels Jan 2, 2024
tastybento added a commit that referenced this issue Jan 2, 2024
@tastybento
Uses latest Visit API to avoid chat spam. Fixes #299
41e437a
@tastybento tastybento linked a pull request Jan 2, 2024 that will close this issue
Uses latest Visit API to avoid chat spam. Fixes #299 #300
Merged
tastybento added a commit that referenced this issue Jan 2, 2024
@tastybento
Uses latest Visit API to avoid chat spam. Fixes #299 (#300)
2b373f6
@tastybento tastybento added done this has been completed and removed in progress this is being worked on labels Jan 2, 2024
@tastybento
Copy link
Member

@IAISI This was due to Level not using the latest version of Visit where these queries can be made silently.

tastybento added a commit that referenced this issue Jan 14, 2024
@tastybento @HSGamer
@Rubenicos @Pirgosth @gitlocalize-app @mt-gitlocalize @huijiyun @NathanAdhitya @organizatsiya @chickiyeah @Rikamo1 @andris155 @BONNe @KrazyxWolf @DeadSilenceIV @wiktorm12 @emmanuelvlad @1cupdragon @DevSolaris @ceze88 @NetheriteTree @DustyGanteng @Poslovitch @ChrissTM03 @Espantonius @PapiCapi @GIGABAIT93
Release 2.12.0 (#301)
3061e80 
* Version 2.7.1

* Version 2.7.2

* Use Java 9's takeWhile

* Added placeholder %Level_[gamemode]_rank_value

Fixes #228

* No save on disable (#231)

* Release 2.6.4

* Remove saving to database on disable.

#229

First, the top ten tables are never actually used or loaded. They are
created in memory by loading the island levels. So there is no reason to
keep saving them.
Second, the island level data is saved every time it is changed, so
there is no need to save all of the cache on exit.

* Fixes tests

* Rosestacker (#232)

* Add support for RoseStacker 1.3.0

* Made plugin a Pladdon.

* Version 2.8.0

* Added new placeholders

%Level_%gamemode%_top_island_name_%rank% - lists the island name
%Level_%gamemode%_top_island_members_%rank% - a comma separated list of
team members

#224
#211
#132
#107
#105

* Update to BentoBox API 1.18

* Open up modules for testing access.

* Back support for BentoBox 1.16.5.

* Version 2.8.1

* Speeds up level calculation by doing more chunk scans async.

If chests are scanned, then it will take longer because these have to be
done sync.

#243

* add Vietnamese (#240)

* Raw island level placeholder (#241)

* Changed IslandLevelCalculator minHeight to world minHeight for negative blocks height support since 1.18. (#246)

* Version 2.9.0

* Chinese Translation (#249)

* Translate zh-CN.yml via GitLocalize

* Translate zh-CN.yml via GitLocalize

Co-authored-by: mt-gitlocalize <[email protected]>
Co-authored-by: 织梦 <[email protected]>

* Translate id.yml via GitLocalize (#250)

Co-authored-by: Nathan Adhitya <[email protected]>

* Translate fr.yml via GitLocalize (#251)

Co-authored-by: organizatsiya <[email protected]>

* Korean translation (#252)

* Translate ko.yml via GitLocalize

* Translate ko.yml via GitLocalize

Co-authored-by: chickiyeah <[email protected]>
Co-authored-by: mt-gitlocalize <[email protected]>

* German Translation (#253)

* Translate de.yml via GitLocalize

* Update de.yml

Co-authored-by: Rikamo045 <[email protected]>
Co-authored-by: tastybento <[email protected]>

* Translate hu.yml via GitLocalize (#254)

Co-authored-by: András Marczinkó <[email protected]>

* Version 2.9.1

* Attempt to handle WildStacker spawners

* Fix error lon loading id locale

* Avoid async chunk snapshotting.

Fixes #256

* Update to BentoBox API 1.20.
Replace plugin.yml with spigot-annotations.

Implement customizable TopLevelPanel.

* Fixes some small issues with TopLevelPanel

Add Utils class that contains some useful things.

* Implement customizable DetailsPanel.

Remove old DetailsGUITab due to new implementation.

* Fix failing test.

* Remove blank file

* Added repo for maven plugin snapshots

* Implement feature that allows to sort items in detail panel. (#259)

Apparently, because it is 2 years old request, it got in a state -> implement or drop.

Fixes #192

* Implement calculated value for blocks. (#260)

It is ~ value, as calculation formula cannot be applied per block. At least I think so.

Part of #192

* Update es.yml (#261)

* Implement customizable Values GUI. (#262)

This GUI shows value to all items in game. It also shows max limit of blocks, if it is set.

Fixes of #192

* Support for AdvancedChests was updated. (#266)

* Implements visit/warp actions in top gui

Add 2 new actions for island buttons in TOP GUI:
- Visit -> allows to visit island, but it requires Visit Addon
- Warp -> allows to warp to island, but it requires Warp Addon

Requested via Discord.

* Fixes a Level addon crash on startup.

Level addon crashed at the startup if Visit or Warps addon were not installed. It happened because Level addon main class were implementing Listener interface.
To avoid it and fix the crash, I moved migration listener to a separate class.

Fixes #2012

* Translate pl.yml via GitLocalize (#269)

Co-authored-by: wiktorm12 <[email protected]>

* Translate fr.yml via GitLocalize (#272)

Co-authored-by: organizatsiya <[email protected]>

* Update to Java 17

* Update Github workflow to Java 17

* Adds %Level_[gamemode]_island_level_max% placeholder

This records the lifetime maximum level the island has ever had.
Addresses #271

* Only shows Members or higher in the top members placeholder

Fixes #267

* Add natural log to level-calc formula parsing

Relates to #274

* feat: add island total points + placeholder (#264)

* feat: add island total points + placeholder

* Update IslandLevels.java

* Fix JavaDoc

* Translate zh-CN.yml via GitLocalize (#276)

Co-authored-by: dawnTak <[email protected]>

* Translate nl.yml via GitLocalize (#277)

Co-authored-by: DevSolaris <[email protected]>

* Add ${argLine} to get jacoco coverage

* Updated Jacoco POM

* Add shulker to in chest count (#275)

* Sonar Cloud code smell clean up (#278)

* Refactor placeholders (#279)

* Update ReadMe

* Fix Jacoco

* Remove unused imports

* Remove placeholders from main class

Created a separate class for cleaner code and added a test class.

* Remove dependency

* Add UltimateStacker hook for stacked blocks (#281)

* Create plugin.yml (#282)

* Create plugin.yml

The annotations do not provide the option to define the version dynamically from maven. This should fix that.

* Remove Spigot Plugin Annotations

* Remove plugin-annotation repo

* Updated dependencies

* Version 2.10.1

* Add blocks that should be zero by default as they are available

on the ocean floor. #284

* Chinese (#288)

* Translate zh-CN.yml via GitLocalize

* Translate zh-CN.yml via GitLocalize

---------

Co-authored-by: Jeansou <[email protected]>
Co-authored-by: dawnTak <[email protected]>

* Translate id.yml via GitLocalize (#287)

Co-authored-by: Dusty <[email protected]>

* French (#286)

* Translate fr.yml via GitLocalize

* Translate fr.yml via GitLocalize

* Translate fr.yml via GitLocalize

---------

Co-authored-by: gitlocalize-app[bot] <55277160+gitlocalize-app[bot]@users.noreply.github.com>
Co-authored-by: organizatsiya <[email protected]>
Co-authored-by: Florian CUNY <[email protected]>

* Spanish (#285)

* Translate es.yml via GitLocalize

* Translate es.yml via GitLocalize

---------

Co-authored-by: ChrissTM03 <[email protected]>
Co-authored-by: Espan <[email protected]>

* Version 2.11.0

* Update Github Build script

* Added distribution required for Github Action

* Update Jacoco

* Update pom.xml

* Add config option to disable plugin hooks (#291)

* Update UltimateStacker dependency

* Add config option to disable plugin hooks

* Use 2.0.0 BentoBox API

* Version 2.12.0

* Adds an admin stats command. See #293

* Update tests

* Update to BentoBox 2.0.0 API

* Added test for Stats command

* Try lower version of jacoco

* Changed top ten internally to use islands instead of players as keys (#295)

Added %[gamemode]_top_weighted_value_x% placeholder
#294

* Added more placeholders. #296

Refactored how the top ten maps are structured. In the future, it may be
best to have the key be the island.

* Translate uk.yml via GitLocalize (#297)

Co-authored-by: GIGABAIT <[email protected]>

* Move to 1.20.4

Refactored the calculator code for clarity.

Added Jacoco line to prvent issues with the bigger Material class.

* Added comments on the panel templates.

* Add protection around unknown blockconfig.yml entries. GRASS>SHORT_GRASS

* Uses latest Visit API to avoid chat spam. Fixes #299 (#300)

* Added test class for EquationEvaluator

* Fix merge error

---------

Co-authored-by: Huynh Tien <[email protected]>
Co-authored-by: Rubén <[email protected]>
Co-authored-by: Pierre Dedrie <[email protected]>
Co-authored-by: gitlocalize-app[bot] <55277160+gitlocalize-app[bot]@users.noreply.github.com>
Co-authored-by: mt-gitlocalize <[email protected]>
Co-authored-by: 织梦 <[email protected]>
Co-authored-by: Nathan Adhitya <[email protected]>
Co-authored-by: organizatsiya <[email protected]>
Co-authored-by: chickiyeah <[email protected]>
Co-authored-by: Rikamo045 <[email protected]>
Co-authored-by: András Marczinkó <[email protected]>
Co-authored-by: BONNe <[email protected]>
Co-authored-by: KrazyxWolf <[email protected]>
Co-authored-by: DeadSilenceIV <[email protected]>
Co-authored-by: wiktorm12 <[email protected]>
Co-authored-by: evlad <[email protected]>
Co-authored-by: dawnTak <[email protected]>
Co-authored-by: DevSolaris <[email protected]>
Co-authored-by: DevSolaris <[email protected]>
Co-authored-by: ceze88 <[email protected]>
Co-authored-by: Jeansou <[email protected]>
Co-authored-by: Dusty <[email protected]>
Co-authored-by: Florian CUNY <[email protected]>
Co-authored-by: ChrissTM03 <[email protected]>
Co-authored-by: Espan <[email protected]>
Co-authored-by: PapiCapi <[email protected]>
Co-authored-by: GIGABAIT <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tastybento tastybento

Labels
done this has been completed Type: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Uses latest Visit API to avoid chat spam. Fixes #299 BentoBoxWorld/Level
2 participants
@tastybento @IAISI