New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GameQueueType should be long or int, but is a string #717

Open

RDalcolmo opened this issue Jan 6, 2023 · 1 comment

RDalcolmo commented Jan 6, 2023

The Riot API states that

/lol/spectator/v4/active-games/by-summoner/{encryptedSummonerId}

gameQueueConfigId should return long (but due to how small the numbers are in their list of constants it could also be an int).

However the CurrentGame object returns a string instead

Contributor

xXLAOKOONXx commented Jan 6, 2023

The file to change:
https://github.com/BenFradet/RiotSharp/blob/develop/RiotSharp/Endpoints/SpectatorEndpoint/CurrentGame.cs

TheMatteoD referenced this issue in TheMatteoD/RiotSharp


          Changed GameQueueType to long from string

bb42b2d

TheMatteoD mentioned this issue

Changed GameQueueType to long from string #718

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment