Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There is no loading percentage when exporting frames #23

Open
MirzaIkhsan opened this issue Dec 7, 2022 · 1 comment
Open

There is no loading percentage when exporting frames #23

MirzaIkhsan opened this issue Dec 7, 2022 · 1 comment

Comments

@MirzaIkhsan
Copy link

MirzaIkhsan commented Dec 7, 2022

I think it would be nice if there is some percentage when exporting frames so I can show the progress to the user. Or maybe there are some alternative that I can use to show the percentage to user?

Thanks 😄

@ueman
Copy link
Collaborator

ueman commented Dec 7, 2022

Yeah, this would certainly be nice. I'll gladly accept such a thing as PR.

Even though this seems like a fairly easy change (just increase percentage after each processed frame) this is not trivial since the processing is done on a background isolate. That means there needs to be inter-isolate communication. This also means that the code has to be splitted into an io implementation and a web implementation, since there are no isolates on web.

I'm not entirely sure, but I believe on web this wouldn't help since the processing is currently a blocking operation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants