Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Any plans for web and other platforms? #52

Closed
2 tasks
giorgio79 opened this issue May 7, 2021 · 6 comments
Closed
2 tasks

Any plans for web and other platforms? #52

giorgio79 opened this issue May 7, 2021 · 6 comments

Comments

@giorgio79
Copy link

🚀 Feature Requests

Hello,

Any plans for web and other platforms?
I was looking at other reverse geocoding packages, and the codebases are pretty similar (https://github.com/bazrafkan/google_geocoding) . Might be just enabling sg on the package page?

Contextualize the feature

Describe the feature

Platforms affected (mark all that apply)

  • 📱 iOS
  • 🤖 Android
@giorgio79
Copy link
Author

Created pull request for web, looks like all is needed is adding the platform
#53

I tried to fork the repo and then install it via pubspec, but getting this weird error:
(Probably because the project has a funky setup with some kind of plugin interface...
In pubspec I put

  geocoding:
    git:
      url: https://github.com/giorgio79/flutter-geocoding/tree/master/geocoding/
      ref: master
      publish_to: none
  flutter_chat_ui: ^1.0.2
  #https://pub.dev/packages/flutter_chat_ui

Git error. Command: `git clone --mirror https://github.com/giorgio79/flutter-geocoding/tree/master/geocoding/ C:\Users\User\AppData\Local\Pub\Cache\git\cache\geocoding-f2a0042d85b3a12c080f9fc7de72aa6f8fe2ce3d`
stdout: 
stderr: Cloning into bare repository 'C:\Users\User\AppData\Local\Pub\Cache\git\cache\geocoding-f2a0042d85b3a12c080f9fc7de72aa6f8fe2ce3d'...
fatal: repository 'https://github.com/giorgio79/flutter-geocoding/tree/master/geocoding/' not found
exit code: 128

pub get failed (server unavailable) -- attempting retry 1 in 1 second...

@giorgio79
Copy link
Author

I suspect in pubspec the entire platforms magic could be removed. Looking at other packages like https://github.com/bazrafkan/google_geocoding/blob/master/pubspec.yaml they omitted the platforms and pub.dev seems to test for all platforms: https://pub.dev/packages/google_geocoding/score

@giorgio79
Copy link
Author

Also, if we look at the geocoding platform interface plugin, it is enabled for all platforms https://pub.dev/packages/geocoding_platform_interface/score

@gauravmehta13
Copy link

how to use for web?

@JDDV
Copy link
Contributor

JDDV commented Aug 27, 2021

Hi @giorgio79, We've discussed this briefly if we should implement this or not. Our main concern is that we need to find a service (as mentioned in a comment in your PR you made) for the web support that can do the things we need (geocoding/reverse geocoding) but that is also free to use, reliable, stable, and accurate/good working. We will need to discuss this further and do a bit of research of what is possible and what not. We will look into this in the future, but I can not give you an estimated date when we will know more about this topic, or when we start implementing it.

@JDDV JDDV closed this as completed Aug 27, 2021
@JDDV
Copy link
Contributor

JDDV commented Sep 2, 2021

Hi @giorgio79 , I just made a proposal about this topic. It would help out a lot if you could read the #69 proposal and react to it.
The main problem is that in contrary to Android and Apples geocoding service, a geocoding web service is free to an extend, but paid if you exceed a certain request limit. This problem is all explained in the proposal, and it would help us out a lot if you could react to it!

Thanks in advance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants