-
-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make sidebar pan gesture customizable #82
Comments
I've had a bunch of people submit issues related to this and never knew how to fix it. If you could submit a PR with those fixes that would be great! |
ElteHupkes
added a commit
to ElteHupkes/Xamarin-Sidebar
that referenced
this issue
Feb 28, 2018
Okay, see #83 . Let me know if I missed anything! |
Fixed in: #84 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The pan gesture used to open the sidebar overrides most other gestures in the content view that it targets, and doesn't mark itself as "failed" when it decides to ignore a certain gesture. This makes it very hard to use other gestures in this view. When implementing a custom gesture some success can be achieved by being creative with
ShouldBeRequiredToFailBy...
and the likes, but when you do not have control over the other gesture recognizer (my concrete example: a swipe left to startUITableViewCell
editing mode) you're basically left without options.The solution would be to
false
fromSlideoutPanDelegate.ShouldReceiveTouch()
when the touch is not inside the gesture active area) and / orSidebar.PanGesture
is public, but because the actual_sidebar
is a private property of theSidebarController
it can currently only be accessed with reflection (which is what I'm doing to work around the problem right now).I'd be willing to submit a PR for one or both of these changes if this sounds reasonable to you.
The text was updated successfully, but these errors were encountered: