Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE] SetVideoSettings() API isn't currently usable #139

Open
DrEsteban opened this issue May 21, 2024 · 0 comments
Open

[ISSUE] SetVideoSettings() API isn't currently usable #139

DrEsteban opened this issue May 21, 2024 · 0 comments

Comments

@DrEsteban
Copy link

Issue Type

  • Bug
  • Feature Request
    (It's kinda both... A "design" bug)

Describe the issue
Right now the SetVideoSettings() API is basically unusable. That's because all the setters on the OBSVideoSettings object model are marked as internal - therefore it cannot be edited or even constructed to make changes to it.

I've confirmed that the API works as expected, though, if you simply make the setters public to allow edits. (Another option would be to mark them as init and provide a constructor to allow customizing them.)

In other places where internal setters are used, the API takes that into account by exposing "deconstructed" APIs. (E.g. InputVolume has SetInputVolume(string, float, bool).) But not with SetVideoSettings() - as currently written it's not usable without using JSON or Reflection haxx.

To Reproduce
Try to call the SetVideoSettings() API in any meaningful way, and realize you can't 🙂

Expected behavior
The SetVideoSettings() API, being an exposed API in the library, is actually usable.

Screenshots
N/A

Versions
Latest, as of 5/21/2024

Additional context
N/A

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant